Re: [RFC] add kobject to struct module

Russell King
2003-09-10T23:32:57Z

On Tue, Sep 09, 2003 at 03:24:21PM -0700, Greg KH wrote:
> A while ago we had talked about adding a kobject to struct module. By
> doing this we add support for module paramaters and other module info to
> be exported in sysfs. So here's a patch that does this that is against
> 2.6.0-test4 (it applies with some fuzz, sorry.)

Please excuse my short-sightedness, but I think the following points
haven't been thought deeply enough:

- modules which use their parameters on initialisation only once.
(eg, 3c59x "full_duplex" parameter)

- Also, what about module parameters which modules aren't expecting to
change beneath themselves? (eg, all the watchdog modules)

- Are we opening the floodgates for another round of races and driver
updates?

--
Russell King (rmk@arm.linux.org.uk) http://www.arm.linux.org.uk/personal/
Linux kernel maintainer of:
2.6 ARM Linux - http://www.arm.linux.org.uk/
2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core