public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ryan Arnold <rsa@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, boutcher@us.ibm.com,
	Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: new driver (hvcs) review request and sysfs questions
Date: Tue, 24 Feb 2004 17:28:45 -0800	[thread overview]
Message-ID: <20040225012845.GA3909@kroah.com> (raw)
In-Reply-To: <1077667227.21201.73.camel@SigurRos.rchland.ibm.com>

On Tue, Feb 24, 2004 at 06:00:26PM -0600, Ryan Arnold wrote:
> An example of the vio bus's "devices" sysfs directory is shown below.
> 
> Pow5:/sys/bus/vio/devices # ls
> .               l-lan@3000000c  l-lan@30000010       vty-server@30000004
> ..              l-lan@3000000d  rtc@4001             vty@30000000
> IBM,sp@4000     l-lan@3000000e  v-scsi@30000002
> l-lan@3000000b  l-lan@3000000f  vty-server@30000003

At first glance, why are you using text strings as part of your bus ids?
Bus ids must be unique, so it looks like you can do this by just using
the number after the '@' character, right?

Then, within each device on the bus, you can give it a "name" or "type"
if you want.  You can put the "l-lan", "rtc", "vty*" stuff there, and
not encode it in the bus id (which is not where it belongs.)

> P.S. who is maintainer of the char device tree?

Do you mean /drivers/char?  Not really anyone directly.  Do you have
some char drivers that need to get added there?  What type of drivers
are they?

thanks,

greg k-h

  reply	other threads:[~2004-02-25  1:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-25  0:00 new driver (hvcs) review request and sysfs questions Ryan Arnold
2004-02-25  1:28 ` Greg KH [this message]
2004-02-25  3:12   ` Dave Boutcher
2004-02-25  4:22     ` Greg KH
2004-02-25 11:34       ` Benjamin Herrenschmidt
2004-02-25 15:46         ` device/kobject naming Hollis Blanchard
2004-02-26  0:18           ` Greg KH
2004-02-26 21:31             ` Hollis Blanchard
2004-02-25 16:22 ` new driver (hvcs) review request and sysfs questions Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040225012845.GA3909@kroah.com \
    --to=greg@kroah.com \
    --cc=boutcher@us.ibm.com \
    --cc=hollisb@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rsa@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox