From: Pavel Machek <pavel@suse.cz>
To: Bruno Ducrot <ducrot@poupinou.org>
Cc: Rusty trivial patch monkey Russell <trivial@rustcorp.com.au>,
Andrew Morton <akpm@zip.com.au>,
kernel list <linux-kernel@vger.kernel.org>,
Stefan Seyfried <seife@suse.de>,
acpi-devel@lists.sourceforge.net
Subject: Re: [ACPI] swsusp/s3: Assembly interactions need asmlinkage
Date: Wed, 25 Feb 2004 11:11:00 +0100 [thread overview]
Message-ID: <20040225101100.GA214@elf.ucw.cz> (raw)
In-Reply-To: <20040225083957.GE2869@poupinou.org>
Hi!
> > swsusp/s3 assembly parts, and parts called from assembly are not
> > properly marked asmlinkage; that leads to double fault on resume when
> > someone compiles kernel with regparm. Thanks go to Stefan Seyfried for
> > discovering this. Please apply,
>
> Does acpi_enter_sleep_state_s4bios() have the same issue ?
Yes, it does; I missed that. Thanks. Here's the fix.
Pavel
--- clean/drivers/acpi/hardware/hwsleep.c 2004-02-05 01:53:59.000000000 +0100
+++ linux/drivers/acpi/hardware/hwsleep.c 2004-02-25 11:08:15.000000000 +0100
@@ -359,7 +359,7 @@
*
******************************************************************************/
-acpi_status
+acpi_status asmlinkage
acpi_enter_sleep_state_s4bios (
void)
{
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2004-02-25 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 13:00 swsusp/s3: Assembly interactions need asmlinkage Pavel Machek
2004-02-25 8:39 ` [ACPI] " Bruno Ducrot
2004-02-25 10:11 ` Pavel Machek [this message]
[not found] <A6974D8E5F98D511BB910002A50A6647615F309E@hdsmsx402.hd.intel.com>
2004-03-04 3:28 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040225101100.GA214@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=acpi-devel@lists.sourceforge.net \
--cc=akpm@zip.com.au \
--cc=ducrot@poupinou.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seife@suse.de \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox