From: Christoph Hellwig <hch@infradead.org>
To: "David Martínez Moreno" <ender@debian.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.3-mm4
Date: Thu, 26 Feb 2004 15:59:02 +0000 [thread overview]
Message-ID: <20040226155902.A19918@infradead.org> (raw)
In-Reply-To: <200402261650.15596.ender@debian.org>; from ender@debian.org on Thu, Feb 26, 2004 at 04:50:14PM +0100
On Thu, Feb 26, 2004 at 04:50:14PM +0100, David Martínez Moreno wrote:
Content-Description: clearsigned data
> Attached patch fixes compilation of ini9100u driver and cleans several
> unneeded definitions. It applies cleanly to 2.6.3-mm4 (I think).
>
> Could you please review, because although simple, I'm scared, I don't really
> know if my patch is doing the Right Thing (tm)? Thanks. :-)
it's not 100% correct as the driver should support multiple HBAs.
Here's a better one:
--- 1.21/drivers/scsi/ini9100u.c Wed Feb 4 06:38:11 2004
+++ edited/drivers/scsi/ini9100u.c Thu Feb 26 17:58:20 2004
@@ -180,15 +180,6 @@
static char *setup_str = (char *) NULL;
-static irqreturn_t i91u_intr0(int irq, void *dev_id, struct pt_regs *);
-static irqreturn_t i91u_intr1(int irq, void *dev_id, struct pt_regs *);
-static irqreturn_t i91u_intr2(int irq, void *dev_id, struct pt_regs *);
-static irqreturn_t i91u_intr3(int irq, void *dev_id, struct pt_regs *);
-static irqreturn_t i91u_intr4(int irq, void *dev_id, struct pt_regs *);
-static irqreturn_t i91u_intr5(int irq, void *dev_id, struct pt_regs *);
-static irqreturn_t i91u_intr6(int irq, void *dev_id, struct pt_regs *);
-static irqreturn_t i91u_intr7(int irq, void *dev_id, struct pt_regs *);
-
static void i91u_panic(char *msg);
static void i91uSCBPost(BYTE * pHcb, BYTE * pScb);
@@ -278,7 +269,7 @@
unsigned long flags;
spin_lock_irqsave(dev->host_lock, flags);
- tul_isr((HCS *)hreg->base);
+ tul_isr((HCS *)dev->base);
spin_unlock_irqrestore(dev->host_lock, flags);
return IRQ_HANDLED;
}
next prev parent reply other threads:[~2004-02-26 16:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-26 2:55 2.6.3-mm4 Andrew Morton
2004-02-26 8:22 ` 2.6.3-mm4 Alexander Hoogerhuis
2004-02-26 8:48 ` 2.6.3-mm4 Marc-Christian Petersen
2004-02-26 8:51 ` 2.6.3-mm4 Nuno Silva
2004-02-27 0:48 ` 2.6.3-mm4 Greg KH
2004-02-26 15:50 ` 2.6.3-mm4 David Martínez Moreno
2004-02-26 15:59 ` Christoph Hellwig [this message]
2004-02-26 16:30 ` 2.6.3-mm4 (compile stats) John Cherry
2004-02-26 18:59 ` Mike Fedyk
2004-02-26 19:26 ` John Cherry
2004-02-26 18:50 ` 2.6.3-mm4 Matthias Hentges
2004-02-26 23:35 ` 2.6.3-mm4, sensors broken Prakash K. Cheemplavam
2004-02-27 0:03 ` Andrew Morton
2004-02-27 8:58 ` Prakash K. Cheemplavam
2004-02-27 0:11 ` 2.6.3-mm4 J.A. Magallon
2004-02-27 0:46 ` 2.6.3-mm4 Greg KH
2004-02-27 8:35 ` 2.6.3-mm4 Jean Delvare
2004-02-27 18:16 ` 2.6.3-mm4 Mike Fedyk
2004-02-27 19:59 ` 2.6.3-mm4 Jean Delvare
2004-02-29 7:51 ` 2.6.3-mm4 Mike Fedyk
2004-02-29 10:11 ` 2.6.3-mm4 Jean Delvare
2004-02-27 16:48 ` 2.6.3-mm4 Prakash K. Cheemplavam
2004-02-27 9:00 ` 2.6.3-mm4 Prakash K. Cheemplavam
2004-02-27 23:51 ` 2.6.3-mm4 Adrian Bunk
2004-03-01 8:25 ` MM VM patches was: 2.6.3-mm4 Mike Fedyk
2004-03-01 8:44 ` Nick Piggin
2004-03-01 9:05 ` Mike Fedyk
2004-03-01 9:27 ` Nick Piggin
2004-03-01 9:47 ` Mike Fedyk
2004-03-01 9:10 ` Nick Piggin
2004-03-01 9:52 ` [PATCH] 2.6.4-rc1-mm1: vm-kswapd-incremental-min (was Re: MM VM patches was: 2.6.3-mm4) Nick Piggin
2004-03-01 10:18 ` Andrew Morton
2004-03-01 10:29 ` Nick Piggin
[not found] <A6974D8E5F98D511BB910002A50A6647615F33F5@hdsmsx402.hd.intel.com>
2004-02-26 22:40 ` 2.6.3-mm4 Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040226155902.A19918@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=ender@debian.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox