From: Brian Childs <brian@rentec.com>
To: linux-kernel@vger.kernel.org
Subject: Multicast broken on x86_64 (Patch Included)
Date: Thu, 26 Feb 2004 11:26:54 -0500 [thread overview]
Message-ID: <20040226162652.GG1760@rentec.com> (raw)
csum-partial.c in 2.4.25 and 2.6.3 has a bug that causes it to compute
the checksum incorrectly.
As a result, multicast doesn't work. It looks as though iptables is
also affected.
Anyway, here's a simple patch.
Brian
diff -ruN linux-2.4.25-orig/arch/x86_64/lib/csum-partial.c linux-2.4.25/arch/x86_64/lib/csum-partial.c
--- linux-2.4.25-orig/arch/x86_64/lib/csum-partial.c 2003-06-13 10:51:32.000000000 -0400
+++ linux-2.4.25/arch/x86_64/lib/csum-partial.c 2004-02-26 11:20:17.000000000 -0500
@@ -141,6 +141,6 @@
*/
unsigned short ip_compute_csum(unsigned char * buff, int len)
{
- return ~csum_partial(buff,len,0);
+ return csum_fold(csum_partial(buff,len,0));
}
next reply other threads:[~2004-02-26 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-26 16:26 Brian Childs [this message]
[not found] <20040226162652.GG1760@rentec.com.suse.lists.linux.kernel>
2004-02-26 17:14 ` Multicast broken on x86_64 (Patch Included) Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040226162652.GG1760@rentec.com \
--to=brian@rentec.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox