From: Pavel Machek <pavel@ucw.cz>
To: Tom Rini <trini@kernel.crashing.org>
Cc: "Amit S. Kale" <amitkale@emsyssoft.com>,
kernel list <linux-kernel@vger.kernel.org>,
kgdb-bugreport@lists.sourceforge.net
Subject: Re: [Kgdb-bugreport] [PATCH][3/3] Update CVS KGDB's wrt connect / detach
Date: Thu, 26 Feb 2004 22:45:32 +0100 [thread overview]
Message-ID: <20040226214531.GA397@elf.ucw.cz> (raw)
In-Reply-To: <20040226144155.GQ1052@smtp.west.cox.net>
Hi!
> > 3. putpacket writes the packet and waits for a '+'
> > 4. new gdb sends a protocol initialization packet
> > 5. putpacket reads characters in that packet hoping for an incoming '+'
> > sending out console message packet on each incoming character
> > 6. gdb receives and rejects each console message packet
> >
> > > - Remove ok_packet(), excessive, IMHO.
> >
> > ok_packet is better than littering "OK" all over the place.
>
> I disagree. If ok_packet was anything more than
> strcpy(remcom_out_buffer, "OK") you'd be right.
Amit, he's right, having function just for one strcpy only makes code
harder to read. And it does not even save much typing...
ok_packet(foo);
strcpy(foo,"OK");
...we are talking 2 or 3 characters here....
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2004-02-26 21:46 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-25 21:36 [PATCH][1/3] Update CVS KGDB's serial driver Tom Rini
2004-02-25 21:43 ` [PATCH][2/3] Update CVS KGDB's have kgdb_{schedule,process}_breakpoint Tom Rini
2004-02-25 21:53 ` [PATCH][3/3] Update CVS KGDB's wrt connect / detach Tom Rini
2004-02-26 8:14 ` [Kgdb-bugreport] " Amit S. Kale
2004-02-26 14:41 ` Tom Rini
2004-02-26 16:05 ` Daniel Jacobowitz
2004-02-26 17:44 ` Tom Rini
2004-02-26 23:32 ` Daniel Jacobowitz
2004-03-01 8:12 ` Amit S. Kale
2004-02-26 21:45 ` Pavel Machek [this message]
2004-03-01 8:29 ` Amit S. Kale
2004-02-26 18:08 ` Tom Rini
2004-03-01 8:15 ` Amit S. Kale
2004-02-26 23:30 ` George Anzinger
2004-02-26 23:59 ` Tom Rini
2004-02-27 1:57 ` George Anzinger
2004-02-27 15:49 ` Tom Rini
2004-02-27 22:11 ` George Anzinger
2004-02-27 22:50 ` Tom Rini
2004-03-01 10:18 ` Amit S. Kale
2004-03-01 10:17 ` Amit S. Kale
2004-02-27 17:13 ` Tom Rini
2004-02-27 21:55 ` George Anzinger
2004-03-01 8:36 ` Amit S. Kale
2004-03-01 16:31 ` Tom Rini
2004-02-25 22:59 ` [Kgdb-bugreport] [PATCH][2/3] Update CVS KGDB's have kgdb_{schedule,process}_breakpoint George Anzinger
2004-02-25 23:04 ` Tom Rini
2004-02-25 23:23 ` George Anzinger
2004-02-26 7:30 ` Amit S. Kale
2004-02-26 23:19 ` George Anzinger
2004-03-01 8:32 ` Amit S. Kale
2004-03-02 21:19 ` George Anzinger
2004-03-03 5:13 ` Amit S. Kale
2004-03-04 0:20 ` George Anzinger
2004-03-04 4:58 ` Amit S. Kale
2004-03-11 21:28 ` George Anzinger
2004-03-12 4:44 ` Amit S. Kale
2004-03-12 8:03 ` George Anzinger
2004-03-15 11:20 ` Amit S. Kale
2004-03-15 19:52 ` George Anzinger
2004-03-16 4:30 ` Amit S. Kale
2004-03-16 13:02 ` La Monte H.P. Yarroll
2004-03-16 15:04 ` Amit S. Kale
2004-02-25 23:10 ` [Kgdb-bugreport] [PATCH][1/3] Update CVS KGDB's serial driver George Anzinger
2004-02-25 23:18 ` Tom Rini
2004-02-26 8:25 ` Amit S. Kale
2004-02-26 14:43 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040226214531.GA397@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=amitkale@emsyssoft.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox