Re: [PATCH] 2.6.2, Partition support for SCSI CDROM...

Andrew Morton
2004-02-23T03:00:11Z

"Steven J. Hill" <sjhill@realitydiluted.com> wrote:
>
> Greetings.
>
> This patch enables support for CDROMs that have partitions on
> them, like say SGI and SUN media. It was sent to me by Christoph
> Hellwig and then I cleaned it up a bit. I am posting it more
> for flamebait^Wcomments to see if people are comfortable with it.

> +config BLK_DEV_SR_PARTITIONS
> +config BLK_DEV_SR_PARTITIONS_PER_DEVICE

Do we actually need these config options? Why not hardwire it to some
reasonable upper bound and be done with it?

>
> +#ifdef MODULE
> + /* Check number of partitions specified. */
> + if (partitions < 0)
> + partitions = 0;
> +#endif
> +

Why is this ifdef needed?