Re: [PATCH] 2.6.2, Partition support for SCSI CDROM...

Matthew Wilcox
2004-02-24T17:12:55Z

On Tue, Feb 24, 2004 at 11:51:20AM -0500, Steven J. Hill wrote:
> +/*
> + * Device node mappings are as follows:
> + *
> + * sr0 - first CDROM, whole disk
> + * sr1 - first CDROM, first partition
> + *
> + * [...]
> + *
> + * sr16 - first CDROM, sixteenth partition
> + * sr17 - second CDROM, whole disk
> + * sr18 - second CDROM, first partition

Umm... no. I suspect you mean:

sr15 - first CDROM, fifteenth partition
sr16 - second CDROM, whole disk
sr17 - second CDROM, first partition

But what a bad idea for device names. Why not

sr0 whole disc
sr0a ... sr0o partitions
sr1, sr1a ... sr1o

It's probably too late to be consistent with discs and call them
sra, sra1, ... sra15
srb, srb1, ... srb15

> + * [...]
> + */
> +static int partitions = 16;

15.

--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain