public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: "Kevin P. Fleming" <kpfleming@backtobasicsmgmt.com>,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: S390 block devs on !s390.
Date: Fri, 27 Feb 2004 17:02:46 +0000	[thread overview]
Message-ID: <20040227170246.GC15016@redhat.com> (raw)
In-Reply-To: <20040227165826.GA9352@redhat.com>

On Fri, Feb 27, 2004 at 04:58:26PM +0000, Dave Jones wrote:

 >  > even a higher level one) with "if ARCH_S390"? All that does is add a 
 >  > "depends ARCH_S390" to everything in the file, but it would sure be a 
 >  > lot easier to maintain.
 > 
 > Sure, you force a bool to y if ARCH=S390 at the top.
 > That would work. Probably.

Or even easier..
(Seems to do the right thing on x86 and make menuconfig ARCH=s390

		Dave

--- linux-2.6.3/drivers/s390/block/Kconfig~	2004-02-27 17:00:07.000000000 +0000
+++ linux-2.6.3/drivers/s390/block/Kconfig	2004-02-27 17:00:27.000000000 +0000
@@ -1,3 +1,5 @@
+if ARCH_S390
+
 comment "S/390 block device drivers"
 	depends on ARCH_S390
 
@@ -62,3 +64,5 @@
 	  ioctl functions specific to the dasd driver.
 	  This is only needed if you want to use applications written for
 	  linux-2.4 dasd channel measurement facility interface.
+
+endif

  reply	other threads:[~2004-02-27 17:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-27 13:57 S390 block devs on !s390 Dave Jones
2004-02-27 16:45 ` Kevin P. Fleming
2004-02-27 16:58   ` Dave Jones
2004-02-27 17:02     ` Dave Jones [this message]
2004-02-27 17:09       ` Kevin P. Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040227170246.GC15016@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@osdl.org \
    --cc=kpfleming@backtobasicsmgmt.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox