From: Rusty Russell <rusty@rustcorp.com.au>
To: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] Add a MODULE_VERSION macro
Date: Mon, 01 Mar 2004 16:41:24 +1100 [thread overview]
Message-ID: <20040301062725.844652C39D@lists.samba.org> (raw)
In-Reply-To: Your message of "Fri, 27 Feb 2004 18:38:58 +0200." <CA71EA605D@vcnet.vc.cvut.cz>
In message <CA71EA605D@vcnet.vc.cvut.cz> you write:
> > ifneq ($(filter-out $(modules),$(__modules)),)
> > + $(warning Trouble: $(__modules) )
> > $(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
> > $(warning do not complain if something goes wrong.)
> > endif
>
> Hi Rusty,
> what is this line supposed to do, except making it impossible
> to build kernel modules in temporary directories? Now when I build
> out-of-tree modules, I get 'Trouble:' followed by approximate 16000
> characters listing paths to all modules I have in kernel
Patch below: does it help?
Rusty
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.4-rc1-bk1/scripts/Makefile.modpost tmp/scripts/Makefile.modpost
--- linux-2.6.4-rc1-bk1/scripts/Makefile.modpost 2004-02-29 19:11:38.000000000 +1100
+++ tmp/scripts/Makefile.modpost 2004-03-01 16:40:33.000000000 +1100
@@ -14,7 +14,7 @@ __modules := $(shell head -q -n1 /dev/nu
modules := $(patsubst %.o,%.ko,$(wildcard $(__modules:.ko=.o)))
ifneq ($(filter-out $(modules),$(__modules)),)
- $(warning Trouble: $(__modules) )
+ $(warning Trouble: $(filter-out $(modules),$(__modules)))
$(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
$(warning do not complain if something goes wrong.)
endif
next prev parent reply other threads:[~2004-03-01 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-27 16:38 [PATCH] Add a MODULE_VERSION macro Petr Vandrovec
2004-03-01 5:41 ` Rusty Russell [this message]
2004-03-01 12:02 ` Petr Vandrovec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040301062725.844652C39D@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=VANDROVE@vc.cvut.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox