* [PATCH] vicam ioctl VIDIOCSWIN wrong return value
@ 2004-03-01 22:50 Frank Cusack
0 siblings, 0 replies; only message in thread
From: Frank Cusack @ 2004-03-01 22:50 UTC (permalink / raw)
To: lkml
Should this return -EINVAL? (credit to Paul Menage).
diff -urp linux-2.4.25/drivers/usb/vicam.c linux-2.4.25.1/drivers/usb/vicam.c
--- linux-2.4.25/drivers/usb/vicam.c 2004-02-18 05:36:31.000000000 -0800
+++ linux-2.4.25.1/drivers/usb/vicam.c 2004-03-01 14:47:59.000000000 -0800
@@ -612,7 +612,7 @@ vicam_ioctl(struct video_device *dev, un
DBG("VIDIOCSWIN %d x %d\n", vw->width, vw->height);
if ( vw.width != 320 || vw.height != 240 )
- retval = -EFAULT;
+ retval = -EINVAL;
break;
}
/fc
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-03-01 22:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-01 22:50 [PATCH] vicam ioctl VIDIOCSWIN wrong return value Frank Cusack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox