Re: [Kgdb-bugreport] [PATCH][3/3] Update CVS KGDB's wrt connect / detach

[Tom Rini <trini@kernel.crashing.org>]

On Mon, Mar 01, 2004 at 02:06:17PM +0530, Amit S. Kale wrote:
> On Friday 27 Feb 2004 5:00 am, George Anzinger wrote:
> > Amit S. Kale wrote:
> > > On Thursday 26 Feb 2004 3:23 am, Tom Rini wrote:
> > >>- Don't try and look for a connection in put_packet, after we've tried
> > >>  to put a packet.  Instead, when we receive a packet, GDB has
> > >>  connected.
> > >
> > > We have to check for gdb connection in putpacket or else following
> > > problem occurs.
> > >
> > > 1. kgdb console messages are to be put.
> > > 2. gdb dies
> > > 3. putpacket writes the packet and waits for a '+'
> >
> > Oops!  Tom, this '+' will be sent under interrupt and while kgdb is not
> > connected.  Looks like it needs to be passed through without causing a
> > breakpoint.  Possible salvation if we disable interrupts while waiting for
> > the '+' but I don't think that is a good idea.
> 
> Yes. That's why I added a paramter to putpacket to skip causing a breakpoint 
> when not required.

The problem, and I think I've fixed it, is you always need to look for a
packet when you're sending one (think of gdb going away on you, you
don't really know what you'll be sending when it does), and you can only
look for a '$'.  That's what I've committed now does.

-- 
Tom Rini
http://gate.crashing.org/~trini/