From: Jens Axboe <axboe@suse.de>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: Redundant unplug_timer deletion
Date: Mon, 1 Mar 2004 23:06:46 +0100 [thread overview]
Message-ID: <20040301220646.GB5033@suse.de> (raw)
In-Reply-To: <B05667366EE6204181EABE9C1B1C0EB501F2AB4D@scsmsx401.sc.intel.com>
On Mon, Mar 01 2004, Chen, Kenneth W wrote:
> The only path to get to del_timer call in __generic_unplug_device()
> is when blk_remove_plug() returns 1, and in that case it already
> removed the unplug_timer.
>
> Patch to remove this redundant call.
>
> - Ken
>
> --- linux-2.6.3/drivers/block/ll_rw_blk.c 2004-02-17 19:57:16
> +++ linux-2.6.3.blk/drivers/block/ll_rw_blk.c 2004-03-01 13:29:37
> @@ -1136,8 +1136,6 @@ static inline void __generic_unplug_devi
> if (!blk_remove_plug(q))
> return;
>
> - del_timer(&q->unplug_timer);
> -
> /*
> * was plugged, fire request_fn if queue has stuff to do
> */
Patch looks good.
--
Jens Axboe
prev parent reply other threads:[~2004-03-01 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-01 21:38 Redundant unplug_timer deletion Chen, Kenneth W
2004-03-01 22:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040301220646.GB5033@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox