* Redundant unplug_timer deletion
@ 2004-03-01 21:38 Chen, Kenneth W
2004-03-01 22:06 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Chen, Kenneth W @ 2004-03-01 21:38 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton
The only path to get to del_timer call in __generic_unplug_device()
is when blk_remove_plug() returns 1, and in that case it already
removed the unplug_timer.
Patch to remove this redundant call.
- Ken
--- linux-2.6.3/drivers/block/ll_rw_blk.c 2004-02-17 19:57:16
+++ linux-2.6.3.blk/drivers/block/ll_rw_blk.c 2004-03-01 13:29:37
@@ -1136,8 +1136,6 @@ static inline void __generic_unplug_devi
if (!blk_remove_plug(q))
return;
- del_timer(&q->unplug_timer);
-
/*
* was plugged, fire request_fn if queue has stuff to do
*/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Redundant unplug_timer deletion
2004-03-01 21:38 Redundant unplug_timer deletion Chen, Kenneth W
@ 2004-03-01 22:06 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2004-03-01 22:06 UTC (permalink / raw)
To: Chen, Kenneth W; +Cc: linux-kernel, Andrew Morton
On Mon, Mar 01 2004, Chen, Kenneth W wrote:
> The only path to get to del_timer call in __generic_unplug_device()
> is when blk_remove_plug() returns 1, and in that case it already
> removed the unplug_timer.
>
> Patch to remove this redundant call.
>
> - Ken
>
> --- linux-2.6.3/drivers/block/ll_rw_blk.c 2004-02-17 19:57:16
> +++ linux-2.6.3.blk/drivers/block/ll_rw_blk.c 2004-03-01 13:29:37
> @@ -1136,8 +1136,6 @@ static inline void __generic_unplug_devi
> if (!blk_remove_plug(q))
> return;
>
> - del_timer(&q->unplug_timer);
> -
> /*
> * was plugged, fire request_fn if queue has stuff to do
> */
Patch looks good.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-03-01 22:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-01 21:38 Redundant unplug_timer deletion Chen, Kenneth W
2004-03-01 22:06 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox