From: Pavel Machek <pavel@ucw.cz>
To: "Amit S. Kale" <akale@users.sourceforge.net>,
kernel list <linux-kernel@vger.kernel.org>
Subject: kgdb: fix kgdbeth compilation and make it init late enough
Date: Tue, 2 Mar 2004 12:25:00 +0100 [thread overview]
Message-ID: <20040302112500.GA485@elf.ucw.cz> (raw)
Hi!
CONFIG_NO_KGDB_CPUS can not be found anywhere in the patches => its
probably not needd any more. init_kgdboe can't be module_initcall; in
such cases it initializes after tg3 network card (and that's bad).
Okay to commit?
Pavel
--- clean-mm/drivers/net/kgdb_eth.c 2004-03-01 22:03:55.000000000 +0100
+++ linux-mm/drivers/net/kgdb_eth.c 2004-03-01 23:00:07.000000000 +0100
@@ -157,15 +157,6 @@
static int init_kgdboe(void)
{
-#ifdef CONFIG_SMP
- if (num_online_cpus() > CONFIG_NO_KGDB_CPUS) {
- printk
- ("kgdb: too manu cpus. Cannot enable debugger with more than %d cpus\n",
- CONFIG_NO_KGDB_CPUS);
- return -1;
- }
-#endif
-
if (!np.remote_ip || netpoll_setup(&np))
return 1;
@@ -176,4 +167,4 @@
return 0;
}
-module_init(init_kgdboe);
+late_initcall(init_kgdboe); /* This needs to be done after netcard is initialized */
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next reply other threads:[~2004-03-02 11:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-02 11:25 Pavel Machek [this message]
2004-03-02 15:32 ` kgdb: fix kgdbeth compilation and make it init late enough Tom Rini
2004-03-02 22:28 ` Pavel Machek
2004-03-02 22:43 ` Tom Rini
2004-03-03 1:04 ` George Anzinger
2004-03-02 22:33 ` Pavel Machek
2004-03-03 1:05 ` George Anzinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040302112500.GA485@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akale@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox