From: Andrea Arcangeli <andrea@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, mbligh@aracnet.com,
hugh@veritas.com, wli@holomorphy.com
Subject: Re: 230-objrmap fixes for 2.6.3-mjb2
Date: Wed, 3 Mar 2004 18:06:24 +0100 [thread overview]
Message-ID: <20040303170624.GP4922@dualathlon.random> (raw)
In-Reply-To: <20040303025820.2cf6078a.akpm@osdl.org>
On Wed, Mar 03, 2004 at 02:58:20AM -0800, Andrew Morton wrote:
> Andrea Arcangeli <andrea@suse.de> wrote:
> >
> > --- sles-objrmap/mm/rmap.c.~1~ 2004-03-03 06:45:38.995594456 +0100
> > +++ sles-objrmap/mm/rmap.c 2004-03-03 07:01:39.200621104 +0100
> > @@ -470,7 +470,7 @@ try_to_unmap_obj_one(struct vm_area_stru
> > if (!pte)
> > goto out;
> >
> > - if (vma->vm_flags & VM_LOCKED) {
> > + if (vma->vm_flags & (VM_LOCKED|VM_RESERVED)) {
> > ret = SWAP_FAIL;
> > goto out_unmap;
>
> I keep on wanting to put that in there too. But pages in a VM_RESERVED vma
> should not find their way onto the LRU. Maybe we should be checking for
> that in do_no_page().
you're right, so we can turn this into a BUG_ON, I prefer it here, since
this is really the place that VM_RESERVED is mean to guard against (plus
the vma merging).
thanks for the explanation.
next prev parent reply other threads:[~2004-03-03 17:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-03 7:09 230-objrmap fixes for 2.6.3-mjb2 Andrea Arcangeli
2004-03-03 10:58 ` Andrew Morton
2004-03-03 15:46 ` Martin J. Bligh
2004-03-03 15:58 ` Dave McCracken
2004-03-03 16:08 ` Christoph Hellwig
2004-03-03 19:04 ` Mike Kravetz
2004-03-04 15:41 ` Rik van Riel
2004-03-04 15:47 ` Christoph Hellwig
2004-03-04 16:21 ` Rik van Riel
2004-03-04 17:03 ` Matt Mackall
2004-03-03 16:57 ` Andrea Arcangeli
2004-03-03 17:07 ` Dave McCracken
2004-03-03 18:39 ` Andrea Arcangeli
2004-03-03 18:44 ` Dave McCracken
2004-03-03 18:51 ` Andrea Arcangeli
2004-03-03 19:01 ` Dave McCracken
2004-03-03 21:05 ` Andrea Arcangeli
2004-03-03 21:39 ` Martin J. Bligh
2004-03-03 23:16 ` Andrea Arcangeli
2004-03-03 17:06 ` Andrea Arcangeli [this message]
2004-03-03 15:54 ` Martin J. Bligh
2004-03-03 16:14 ` Andrea Arcangeli
2004-03-25 21:45 ` Andrea Arcangeli
2004-03-26 11:57 ` Hugh Dickins
2004-03-26 18:02 ` Andrea Arcangeli
2004-03-26 23:25 ` Andrew Morton
2004-03-27 14:24 ` Andrea Arcangeli
2004-03-27 15:29 ` Dave McCracken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040303170624.GP4922@dualathlon.random \
--to=andrea@suse.de \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox