public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <willy@w.ods.org>
To: Armin Schindler <aml@melware.de>
Cc: Willy Tarreau <willy@w.ods.org>,
	Armin Schindler <armin@melware.de>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.4] sys_select() return error on bad file
Date: Thu, 4 Mar 2004 14:48:09 +0100	[thread overview]
Message-ID: <20040304134809.GA482@alpha.home.local> (raw)
In-Reply-To: <Pine.LNX.4.31.0403041016190.16757-100000@phoenix.one.melware.de>

On Thu, Mar 04, 2004 at 10:20:41AM +0100, Armin Schindler wrote:
 
> retval cannot be used for that, it may get changed in the loop.

OK

> Anyway, I don't see how your proposal would do better performance?
> My patch just adds a new variable on the stack, which should not make any
> difference in performance. And later, it is the same if the new or another
> variable gets changed or checked.

It is possible that in current code the, compiler is able to allocate a
register for each variable used inside the loop, while it may not be able
anymore with an additionnal variable. But that's just speculation anyway.

Cheers,
Willy

  reply	other threads:[~2004-03-04 14:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-03  8:46 [PATCH 2.4] sys_select() return error on bad file Armin Schindler
2004-03-04  7:22 ` Willy Tarreau
2004-03-04  9:20   ` Armin Schindler
2004-03-04 13:48     ` Willy Tarreau [this message]
2004-03-14 15:58     ` Marcelo Tosatti
  -- strict thread matches above, loose matches on Subject: below --
2004-03-14 18:18 Manfred Spraul
2004-03-15 10:33 ` Armin Schindler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040304134809.GA482@alpha.home.local \
    --to=willy@w.ods.org \
    --cc=aml@melware.de \
    --cc=armin@melware.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox