* [PATCH] mismatched syscall protos.
@ 2004-03-05 22:55 Dave Jones
0 siblings, 0 replies; only message in thread
From: Dave Jones @ 2004-03-05 22:55 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton; +Cc: Linux Kernel
Sparse noticed a bunch of mismatched prototypes in the new syscalls.h file
when compiling net/socket.c Whilst most of them are just missing __user
tags, the last argument of sys_socketpair was completely different.
Dave
--- bk-linus/include/linux/syscalls.h~ Fri Mar 5 17:52:01 2004
+++ bk-linus/include/linux/syscalls.h Fri Mar 5 17:55:40 2004
@@ -386,24 +386,24 @@
unsigned int count);
asmlinkage long sys_setsockopt(int fd, int level, int optname,
- char *optval, int optlen);
+ char __user *optval, int optlen);
asmlinkage long sys_getsockopt(int fd, int level, int optname,
char __user *optval, int __user *optlen);
-asmlinkage long sys_bind(int, struct sockaddr *, int);
-asmlinkage long sys_connect(int, struct sockaddr *, int);
-asmlinkage long sys_accept(int, struct sockaddr *, int *);
-asmlinkage long sys_getsockname(int, struct sockaddr *, int *);
-asmlinkage long sys_getpeername(int, struct sockaddr *, int *);
-asmlinkage long sys_send(int, void *, size_t, unsigned);
-asmlinkage long sys_sendto(int, void *, size_t, unsigned,
- struct sockaddr *, int);
+asmlinkage long sys_bind(int, struct sockaddr __user *, int);
+asmlinkage long sys_connect(int, struct sockaddr __user *, int);
+asmlinkage long sys_accept(int, struct sockaddr __user *, int __user *);
+asmlinkage long sys_getsockname(int, struct sockaddr __user *, int __user *);
+asmlinkage long sys_getpeername(int, struct sockaddr __user *, int __user *);
+asmlinkage long sys_send(int, void __user *, size_t, unsigned);
+asmlinkage long sys_sendto(int, void __user *, size_t, unsigned,
+ struct sockaddr __user *, int);
asmlinkage long sys_sendmsg(int fd, struct msghdr __user *msg, unsigned flags);
-asmlinkage long sys_recv(int, void *, size_t, unsigned);
-asmlinkage long sys_recvfrom(int, void *, size_t, unsigned,
- struct sockaddr *, int *);
+asmlinkage long sys_recv(int, void __user *, size_t, unsigned);
+asmlinkage long sys_recvfrom(int, void __user *, size_t, unsigned,
+ struct sockaddr __user *, int __user *);
asmlinkage long sys_recvmsg(int fd, struct msghdr __user *msg, unsigned flags);
asmlinkage long sys_socket(int, int, int);
-asmlinkage long sys_socketpair(int, int, int, int [2]);
+asmlinkage long sys_socketpair(int, int, int, int __user *);
asmlinkage long sys_socketcall(int call, unsigned long __user *args);
asmlinkage long sys_listen(int, int);
asmlinkage long sys_poll(struct pollfd __user *ufds, unsigned int nfds,
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-03-05 22:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-05 22:55 [PATCH] mismatched syscall protos Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox