public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: linux-kernel@vger.kernel.org
Cc: sneakums@zork.net
Subject: Re: [PATCH] 2.6 ide-cd DMA ripping
Date: Mon, 8 Mar 2004 10:41:19 +0100	[thread overview]
Message-ID: <20040308094119.GS23525@suse.de> (raw)
In-Reply-To: <6u7jxwn9sb.fsf@zork.zork.net>

On Sun, Mar 07 2004, Sean Neakums wrote:
> Jens Axboe <axboe@suse.de> writes:
> 
> > On Sat, Mar 06 2004, Sean Neakums wrote:
> >> Jens Axboe <axboe@suse.de> writes:
> >> 
> >> > Hi,
> >> >
> >> > 2.6 still uses PIO for CDROMREADAUDIO cdda ripping, which is less than
> >> > optimal of course... This patch uses the block layer infrastructure to
> >> > enable zero copy DMA ripping through CDROMREADAUDIO.
> >> >
> >> > I'd appreciate people giving this a test spin. Patch is against
> >> > 2.6.4-rc1 (well current BK, actually).
> >> 
> >> Applied successfully to 2.6.4-rc1-mm2, and it works great.  For some
> >> reason, on two different machines, ripping with cdparanoia used to
> >> somehow crowd out the serial port, but now everything just works.
> >
> > cd ripping was highly cpu intensive when it ran in pio, so it's very
> > likely that this screwed up your serial port communication. It doesn't
> > matter with the patch, but had you used hdparm -u1 on your cd device
> > on an unpatched kernel, you would have had better luck.
> 
> I had a look, just for pig iron, and hdparm -u on one of the machines
> reports that it is already enabled.  That machine is SMP with two
> 1.13GHz PIIIs.  I can't check the other machine as the drive in
> question is no longer functional.

Then isr runtime was likely too high, even with interrupt masking
enabled. So just be glad that it works with dma :)

-- 
Jens Axboe


  reply	other threads:[~2004-03-08  9:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-03 11:37 [PATCH] 2.6 ide-cd DMA ripping Jens Axboe
2004-03-03 11:45 ` Jens Axboe
2004-03-03 12:26 ` Alistair John Strachan
2004-03-03 12:25   ` Jens Axboe
2004-03-06 14:04 ` Sean Neakums
2004-03-07 10:35   ` Jens Axboe
2004-03-07 12:04     ` Sean Neakums
2004-03-08  9:41       ` Jens Axboe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-03-04 11:07 Vince
2004-03-04 15:28 ` [PATCH] " Jens Axboe
2004-03-05 12:08   ` Colin Leroy
2004-03-05 12:21     ` Jens Axboe
2004-03-05 13:15       ` Colin Leroy
2004-03-05 13:22         ` Jens Axboe
2004-03-05 18:58 Voluspa
2004-03-07 10:34 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040308094119.GS23525@suse.de \
    --to=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sneakums@zork.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox