public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Philippe Elie <phil.el@wanadoo.fr>
To: Andrew Morton <akpm@osdl.org>
Cc: Andreas Schwab <schwab@suse.de>,
	thomas.schlichter@web.de, linux-kernel@vger.kernel.org
Subject: Re: [2.6.4-rc2] bogus semicolon behind if()
Date: Tue, 9 Mar 2004 07:01:27 +0000	[thread overview]
Message-ID: <20040309070127.GA2958@zaniah> (raw)
In-Reply-To: <20040308162947.4d0b831a.akpm@osdl.org>

On Mon, 08 Mar 2004 at 16:29 +0000, Andrew Morton wrote:

> Andreas Schwab <schwab@suse.de> wrote:
> >
> > Thomas Schlichter <thomas.schlichter@web.de> writes:
> > 
> > > P.S.: Wouldn't it be nice if gcc complained about these mistakes?
> > 
> > Among these 18 cases are 13 false positives. :-)
> 
> Rename Thomas's script to crappy-code-detector.sh and its hit rate goes to
> 100% ;)
> 

Was this patch so crappy ? http://tinyurl.com/2jbe4 , 

-				check_nmi_watchdog();
+				if (check_nmi_watchdog() < 0);
+					timer_ack = !cpu_has_tsc


regards,
Phil


  reply	other threads:[~2004-03-09  6:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-08 23:14 [2.6.4-rc2] bogus semicolon behind if() Thomas Schlichter
2004-03-08 23:43 ` Andreas Schwab
2004-03-08 23:56   ` Thomas Schlichter
2004-03-09  0:29   ` Andrew Morton
2004-03-09  7:01     ` Philippe Elie [this message]
2004-03-09 11:08       ` Thomas Schlichter
2004-03-10  6:08         ` Philippe Elie
2004-03-10 16:20           ` Zwane Mwaikambo
2004-03-17 17:20           ` Maciej W. Rozycki
2004-03-17 16:51         ` Maciej W. Rozycki
2004-03-17 18:25           ` Andrew Morton
2004-03-17 18:50             ` Maciej W. Rozycki
2004-03-18  9:46               ` Mikael Pettersson
2004-03-18  9:52                 ` Andrew Morton
2004-03-21  3:51             ` Zwane Mwaikambo
2004-03-21  3:55               ` Zwane Mwaikambo
2004-03-19 19:01           ` Thomas Schlichter
2004-03-19 20:30             ` Maciej W. Rozycki
2004-03-19 23:13               ` Thomas Schlichter
2004-03-09  0:33 ` Andrew Morton
2004-03-09 11:09   ` Thomas Schlichter
  -- strict thread matches above, loose matches on Subject: below --
2004-03-20 17:04 Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040309070127.GA2958@zaniah \
    --to=phil.el@wanadoo.fr \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwab@suse.de \
    --cc=thomas.schlichter@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox