* [PATCH] class_simple cleanup in sg
@ 2004-03-04 4:06 Chris Wright
2004-03-11 1:29 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Chris Wright @ 2004-03-04 4:06 UTC (permalink / raw)
To: greg; +Cc: linux-kernel
The only spot that seems to care about class_simple_device_add possibly
failing, but it gets the wrong error test.
===== drivers/scsi/sg.c 1.81 vs edited =====
--- 1.81/drivers/scsi/sg.c Fri Feb 6 00:21:23 2004
+++ edited/drivers/scsi/sg.c Wed Mar 3 19:56:13 2004
@@ -1439,7 +1439,7 @@
MKDEV(SCSI_GENERIC_MAJOR, k),
cl_dev->dev, "%s",
disk->disk_name);
- if (NULL == sg_class_member)
+ if (IS_ERR(sg_class_member))
printk(KERN_WARNING "sg_add: "
"class_simple_device_add failed\n");
class_set_devdata(sg_class_member, sdp);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] class_simple cleanup in sg
2004-03-04 4:06 [PATCH] class_simple cleanup in sg Chris Wright
@ 2004-03-11 1:29 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2004-03-11 1:29 UTC (permalink / raw)
To: Chris Wright; +Cc: linux-kernel
On Wed, Mar 03, 2004 at 08:06:25PM -0800, Chris Wright wrote:
> The only spot that seems to care about class_simple_device_add possibly
> failing, but it gets the wrong error test.
Applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-03-11 1:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-04 4:06 [PATCH] class_simple cleanup in sg Chris Wright
2004-03-11 1:29 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox