Re: 2.6.4-mm1

Andi Kleen
2004-03-11T23:37:43Z

On Thu, Mar 11, 2004 at 09:43:54PM +0000, Joe Thornber wrote:
> On Thu, Mar 11, 2004 at 03:48:29PM +0100, Andi Kleen wrote:
> > Maybe they have broken data structures again, most likely
> > because of different long long alignment. A lot of people
> > who attempt to design data structures that don't need translation
> > get that wrong unfortunately.
>
> I'd thought we'd been careful about this. You're suggesting that the
> size of this structure has changed between kernel versions ?!
>
> struct dm_ioctl {
> uint32_t version[3];
> uint32_t data_size;
>
> uint32_t data_start;
>
> uint32_t target_count;
> int32_t open_count;
> uint32_t flags;
> uint32_t event_nr;
> uint32_t padding;
>
> uint64_t dev;
>
> char name[DM_NAME_LEN];
> char uuid[DM_UUID_LEN];

Are DM_NAME_LEN and DM_UUID_LEN not both a multiple of 8?

> };

There are more structures here, right?

If yes, that's the problem.

-Andi