Re: PATCH: Shutdown IDE before powering off.

John Bradford
2004-01-22T08:05:35Z

Quote from Andrew Morton <akpm@osdl.org>:
> Nigel Cunningham <ncunningham@users.sourceforge.net> wrote:
> >
> > +static void ide_drive_shutdown (struct device * dev)
> > +{
> > + generic_ide_suspend(dev, 5);
> > +}
> > +
> > int ide_register_driver(ide_driver_t *driver)
> > {
> > struct list_head list;
> > @@ -2519,6 +2524,7 @@
> > driver->gen_driver.name = (char *) driver->name;
> > driver->gen_driver.bus = &ide_bus_type;
> > driver->gen_driver.remove = ide_drive_remove;
> > + driver->gen_driver.shutdown = ide_drive_shutdown;
>
> This spins down the disk(s) when you're just doing do a reboot. That's
> fairly irritating and could affect reboot times if one has many disks.

I think it is an attempt to force some broken drives to flush their
cache, but I wonder whether it will simply move the problem from one
set of broken drives to another :-).

John.