Re: [PATCH] ethtool.h should use userspace-accessible types

Eric W. Biederman
2004-03-12T16:34:04Z

Eric Brower <ebrower@usa.net> writes:

> Attached is a patch to 2.4's ethtool.h to use appropriate, userspace-accessible
> data types (__u8 and friends, rather than u8 and friends).

Why there is no #ifdef __KERNEL__ in this header to make it userspace
safe.

> I've also posted a patch against ethtool-1.8 to the sf.net gkernel site that
> cleans-up ethtool-copy.h and the rest in the same manner.

In user space the types from stdint.h likely should be used. So __u8
and friends looks wrong there as well.

Eric