Re: objrmap-core-1 (rmap removal for file mappings to avoid 4:4 in <=16G machines)

Andrew Morton
2004-03-08T23:19:28Z

Andrea Arcangeli <andrea@suse.de> wrote:
>
> > Other issues are how it will play with remap_file_pages(), and how it
> > impacts Ingo's work to permit remap_file_pages() to set page permissions on
> > a per-page basis. This change provides large performance improvements to
>
> in the current form it should be using pte_chains still for nonlinear
> vmas, see the function that pretends to convert the page to be like
> anonymous memory (which simply means to use pte_chains for the reverse
> mappings). I admit I didn't focus much on that part though, I trust
> Dave on that ;), since I want to drop it.
>
> What I want to do with the nonlinear vmas is to scan all the ptes in
> every nonlinear vma, so I don't have to allocate the pte_chain and the
> swapping procedure will simply be more cpu hungry under nonlinear vmas.
> I'm not interested to provide optimal performance in swapping nonlinear
> vmas, I prefer the fast path to be as fast as possible and without
> memory overhead.

OK. There was talk some months ago about making the non-linear vma's
effectively mlocked and unswappable. That would reduce their usefulness
significantly. It looks like that's off the table now, which is good.

btw, mincore() has always been broken with nonlinear vma's. If you could
fix that up some time using that pagetable walker it would be nice. It's
not very important though.