From: Greg KH <greg@kroah.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390 (8/10): zfcp fixes.
Date: Fri, 12 Mar 2004 17:40:53 -0800 [thread overview]
Message-ID: <20040313014053.GA10930@kroah.com> (raw)
In-Reply-To: <20040312193816.GI2757@mschwid3.boeblingen.de.ibm.com>
On Fri, Mar 12, 2004 at 08:38:16PM +0100, Martin Schwidefsky wrote:
> zfcp host adapter fixes:
> - Reuse freed scsi_ids and scsi_luns for mappings.
> - Order list of ports/units by assigned scsi_id/scsi_lun.
> - Don't update max_id/max_lun in scsi_host anymore.
> - Get rid of all magics.
> - Add owner field to ccw_driver structure.
> - Replace release function for device structures by kfree. Move struct
> device to the start of struct zfcp_port/zfcp_unit to make it work.
Ick, ick, ick!
Why? Please do not do this, as it is not needed, and completly
unnecessary. The fact that you have to create a cast like:
> + unit->sysfs_device.release = (void (*)(struct device *))kfree;
Should set off all kinds of "this is a something we should not be doing"
warning flags.
thanks,
greg k-h
next prev parent reply other threads:[~2004-03-13 1:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-12 19:38 [PATCH] s390 (8/10): zfcp fixes Martin Schwidefsky
2004-03-12 20:19 ` Christoph Hellwig
2004-03-13 1:40 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-03-12 20:29 Martin Schwidefsky
2004-03-13 1:41 ` Greg KH
2004-03-15 9:18 ` Martin Schwidefsky
2004-03-16 17:08 ` Greg KH
2004-03-16 13:51 Martin Schwidefsky
2004-03-16 21:52 ` James Bottomley
2004-03-17 10:35 ` Heiko Carstens
2004-03-17 12:06 Martin Schwidefsky
2004-03-29 10:03 Martin Schwidefsky
2004-03-30 1:37 ` Greg KH
2004-03-31 17:57 Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040313014053.GA10930@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox