public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390 (8/10): zfcp fixes.
Date: Fri, 12 Mar 2004 17:41:56 -0800	[thread overview]
Message-ID: <20040313014156.GB10930@kroah.com> (raw)
In-Reply-To: <OF6FA69BBA.80AB3A29-ONC1256E55.0070477F-C1256E55.00708AF1@de.ibm.com>

On Fri, Mar 12, 2004 at 09:29:16PM +0100, Martin Schwidefsky wrote:
> 
> 
> 
> 
> Hi Christoph,
> 
> > >  - Replace release function for device structures by kfree. Move struct
> > >    device to the start of struct zfcp_port/zfcp_unit to make it work.
> >
> > That's ugly as hell.  Actually even more ugly.  It's not that ->release
> > is such a performance critical path that you absolutely need to avoid one
> > level of function calls.  So please put a simple wrapper back instead of
> > the horrible casts and suddenly the silly placement restrictions are gone,
> > too.
> 
> That it's ugly is true. But what's important is that it is required to get
> module ref-counting right. The release function is called after the last
> module_put has been done.

Huh?  Is the scsi reference counting logic that messed up?  If so, it
needs to be fixed.

And if so, why does it not show up with all of the other scsi drivers?

thanks,

greg k-h

  reply	other threads:[~2004-03-13  1:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-12 20:29 [PATCH] s390 (8/10): zfcp fixes Martin Schwidefsky
2004-03-13  1:41 ` Greg KH [this message]
2004-03-15  9:18   ` Martin Schwidefsky
2004-03-16 17:08     ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2004-03-31 17:57 Heiko Carstens
2004-03-29 10:03 Martin Schwidefsky
2004-03-30  1:37 ` Greg KH
2004-03-17 12:06 Martin Schwidefsky
2004-03-16 13:51 Martin Schwidefsky
2004-03-16 21:52 ` James Bottomley
2004-03-17 10:35   ` Heiko Carstens
2004-03-12 19:38 Martin Schwidefsky
2004-03-12 20:19 ` Christoph Hellwig
2004-03-13  1:40 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040313014156.GB10930@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox