From: Andrew Morton <akpm@osdl.org>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] kref, a tiny, sane, reference count object
Date: Sat, 13 Mar 2004 16:34:51 -0800 [thread overview]
Message-ID: <20040313163451.3c841ac2.akpm@osdl.org> (raw)
In-Reply-To: <20040313082003.GA13084@kroah.com>
Greg KH <greg@kroah.com> wrote:
>
> For all of those people, this patch is for you.
It does rather neatly capture a common idiom.
> +struct kref * kref_get(struct kref *kref)
> +{
> + if (kref) {
> + WARN_ON(!atomic_read(&kref->refcount));
> + atomic_inc(&kref->refcount);
> + }
> + return kref;
> +}
Why is a NULL arg permitted here?
> +void kref_cleanup(struct kref *kref)
> +{
> + if (!kref)
> + return;
and here?
next prev parent reply other threads:[~2004-03-14 0:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-13 8:20 [RFC] kref, a tiny, sane, reference count object Greg KH
2004-03-13 8:21 ` [PATCH] convert usb-serial core to use kref instead of kobject Greg KH
2004-03-14 0:34 ` Andrew Morton [this message]
2004-03-14 2:55 ` [RFC] kref, a tiny, sane, reference count object Greg KH
2004-03-14 3:30 ` Nick Piggin
2004-03-14 4:10 ` Andrew Morton
2004-03-14 4:20 ` Nick Piggin
-- strict thread matches above, loose matches on Subject: below --
2004-03-13 9:10 Peter Kjellerstedt
2004-03-13 18:15 ` Greg KH
[not found] <1zcH2-KO-11@gated-at.bofh.it>
2004-03-13 13:06 ` Andi Kleen
2004-03-13 18:14 ` Greg KH
[not found] <1zhdz-5uL-3@gated-at.bofh.it>
[not found] ` <1zhdz-5uL-1@gated-at.bofh.it>
[not found] ` <1zm3F-2ex-7@gated-at.bofh.it>
2004-03-13 20:43 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040313163451.3c841ac2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox