Re: [RFC] kref, a tiny, sane, reference count object

Greg KH
2004-03-14T17:00:12Z

On Sat, Mar 13, 2004 at 04:34:51PM -0800, Andrew Morton wrote:
> > +struct kref * kref_get(struct kref *kref)
> > +{
> > + if (kref) {
> > + WARN_ON(!atomic_read(&kref->refcount));
> > + atomic_inc(&kref->refcount);
> > + }
> > + return kref;
> > +}
>
> Why is a NULL arg permitted here?

Because kobjects permitted it? :)

I think you are correct, if we are passing a NULL pointer to these
functions, we deserve the oops we get, as other, much worse things could
happen (as a kref lives inside another structure.)

I'll go take those checks out.

thanks,

greg k-h