From: Matt Mackall <mpm@selenic.com>
To: Jonathan Lundell <linux@lundell-bros.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ethtool.h should use userspace-accessible types
Date: Sat, 13 Mar 2004 21:25:01 -0600 [thread overview]
Message-ID: <20040314032501.GT20174@waste.org> (raw)
In-Reply-To: <p0610032fbc77de2c9c28@[192.168.0.3]>
On Fri, Mar 12, 2004 at 01:48:54PM -0800, Jonathan Lundell wrote:
> At 10:06 AM -0700 3/12/04, Eric W. Biederman wrote:
> >My intent was to say: Why change the types when there is no #ifdef
> >__KERNEL__ in the header. With no #ifdef __KERNEL__ it exports
> >definitions that are private to the kernel making it not safe for
> >userspace to use. With kernel private definitions in there it will
> >generate name space pollution if included by user space.
>
> Presumably because it *is* included by userspace, because it defines
> the interface between the kernel and userspace; of course userspace
> will (does) include it.
Well that's a bug. You don't include kernel headers in userspace.
Doing so has been deprecated for 8 years and 3 major releases.
--
Matt Mackall : http://www.selenic.com : Linux development and consulting
next prev parent reply other threads:[~2004-03-14 3:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-12 1:54 [PATCH] ethtool.h should use userspace-accessible types Eric Brower
2004-03-12 2:35 ` Tim Hockin
2004-03-12 4:57 ` Greg KH
2004-03-12 9:19 ` Tim Hockin
2004-03-12 16:25 ` Eric W. Biederman
2004-03-12 16:54 ` Jeff Garzik
2004-03-12 17:06 ` Eric W. Biederman
2004-03-12 21:48 ` Jonathan Lundell
2004-03-14 3:25 ` Matt Mackall [this message]
2004-03-15 21:24 ` Jonathan Lundell
2004-03-12 16:54 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040314032501.GT20174@waste.org \
--to=mpm@selenic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@lundell-bros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox