From: Herbert Poetzl <herbert@13thfloor.at>
To: Willy Tarreau <willy@w.ods.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bind Mount Extensions 0.04
Date: Mon, 15 Mar 2004 06:36:55 +0100 [thread overview]
Message-ID: <20040315053654.GA31818@MAIL.13thfloor.at> (raw)
In-Reply-To: <20040315045952.GD14537@alpha.home.local>
On Mon, Mar 15, 2004 at 05:59:52AM +0100, Willy Tarreau wrote:
> Hi Herbert,
>
> On Mon, Mar 15, 2004 at 04:53:51AM +0100, Herbert Poetzl wrote:
>
> > an older version of this patch was included in 2.6.0-test6-mm2,
> > and it is currently used by several people, without any issues,
> > so I'd kindly request to consider it for inclusion into mainline.
>
> I have tested 0.03 on 2.4.25 + some other patches, and discovered something
> annoying : an attempt to change something on the R/O FS marked the parent
> FS busy. But I cannot say for sure that it was a problem with your patch,
> because that kernel had several others. I'll try to reproduce on a naked
> kernel. To reproduce it, you can try this :
it _was_ an issue with 0.03 on 2.4.25 (see changelog)
> # mount /dev/hdaXX /mnt/disk
> # mount -r --bind /mnt/disk /mnt/ro
> # touch /mnt/ro/foo
> Read-only file-system (that's what was expected)
> # umount /mnt/ro
> (I don't remember if the problem already arises here)
> # umount /mnt/disk
> device is busy
this has been fixed in 0.04 for 2.4.25, if you need
the fix to include for 0.03 (for whatever reason)
here is the relevant hunk ..
--- linux-2.4.25-bme0.03/fs/namei.c 2004-03-10 14:45:36.000000000 +0100
+++ linux-2.4.25-bme0.04/fs/namei.c 2004-03-10 12:18:35.000000000 +0100
@@ -1045,7 +1045,7 @@ int open_namei(const char * pathname, in
return error;
error = -EROFS;
if (MNT_IS_RDONLY(nd->mnt))
- return error;
+ goto exit;
/*
* We have the parent and last component. First of all, check
> Other than that, this feature is really excellent !
thanks for using it ...
> Thanks,
> Willy
next prev parent reply other threads:[~2004-03-15 5:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 3:53 [PATCH] Bind Mount Extensions 0.04 Herbert Poetzl
[not found] ` <20040315045952.GD14537@alpha.home.local>
2004-03-15 5:36 ` Herbert Poetzl [this message]
2004-03-15 22:04 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040315053654.GA31818@MAIL.13thfloor.at \
--to=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox