From: Adrian Bunk <bunk@fs.tum.de>
To: Andrew Morton <akpm@osdl.org>, mjander@embedded.cl, perex@suse.cz
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: [patch] 2.6.4-mm2: ALSA au88x0.c doesn't compile with gcc 2.95
Date: Mon, 15 Mar 2004 10:32:56 +0100 [thread overview]
Message-ID: <20040315093256.GS14833@fs.tum.de> (raw)
In-Reply-To: <20040314172809.31bd72f7.akpm@osdl.org>
The following compile error with gcc 2.95 comes from Linus' tree:
<-- snip -->
...
CC sound/pci/au88x0/au8810.o
In file included from sound/pci/au88x0/au8810.c:17:
sound/pci/au88x0/au88x0.c: In function `snd_vortex_workaround':
sound/pci/au88x0/au88x0.c:89: parse error before `int'
sound/pci/au88x0/au88x0.c:93: `rc' undeclared (first use in this function)
sound/pci/au88x0/au88x0.c:93: (Each undeclared identifier is reported only once
sound/pci/au88x0/au88x0.c:93: for each function it appears in.)
make[3]: *** [sound/pci/au88x0/au8810.o] Error 1
<-- snip -->
gcc 2.95 doesn't allow declarations mixed with code.
The fix is simple:
--- linux-2.6.4-mm2-full/sound/pci/au88x0/au88x0.c.old 2004-03-15 10:26:56.000000000 +0100
+++ linux-2.6.4-mm2-full/sound/pci/au88x0/au88x0.c 2004-03-15 10:27:32.000000000 +0100
@@ -71,6 +71,8 @@
static void __devinit snd_vortex_workaround(struct pci_dev *vortex, int fix)
{
struct pci_dev *via = NULL;
+ int rc;
+
/* autodetect if workarounds are required */
while ((via = pci_find_device(PCI_VENDOR_ID_VIA,
PCI_DEVICE_ID_VIA_8365_1, via))) {
@@ -86,8 +88,6 @@
if (fix == 255)
return;
- int rc;
-
/* fix vortex latency */
if (fix & 0x01) {
if (!(rc = pci_write_config_byte(vortex, 0x40, 0xff))) {
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-03-15 9:33 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 1:28 2.6.4-mm2 Andrew Morton
2004-03-15 1:57 ` 2.6.4-mm2 Joshua Kwan
2004-03-15 6:08 ` 2.6.4-mm2 Sam Ravnborg
2004-03-15 9:32 ` Adrian Bunk [this message]
2004-03-15 9:36 ` 2.6.4-mm2: ALSA au88{1,2}0: multiply defined symbols Adrian Bunk
2004-03-15 18:54 ` 2.6.4-mm2 Sam Ravnborg
2004-03-20 22:50 ` 2.6.4-mm2 Olaf Hering
2004-03-15 19:18 ` 2.6.4-mm2 (compile stats) John Cherry
2004-03-15 20:57 ` 2.6.4-mm2 Thomas Schlichter
2004-03-15 21:08 ` 2.6.4-mm2 Thomas Schlichter
2004-03-15 21:18 ` 2.6.4-mm2 Andrew Morton
2004-03-15 21:18 ` 2.6.4-mm2 Jens Axboe
2004-03-15 22:40 ` 2.6.4-mm2 Thomas Schlichter
2004-03-15 22:11 ` 2.6.4-mm2 Jesse Barnes
2004-03-16 18:32 ` 2.6.4-mm2 Daniel McNeil
2004-03-16 21:58 ` 2.6.4-mm2 Chris Mason
2004-03-16 23:21 ` 2.6.4-mm2 Andrew Morton
2004-03-16 23:28 ` 2.6.4-mm2 Andrew Morton
2004-03-16 23:39 ` 2.6.4-mm2 Andrew Morton
2004-03-17 0:10 ` 2.6.4-mm2 Daniel McNeil
[not found] ` <1079485055.4181.1115.camel@watt.suse.com>
[not found] ` <1079487710.3100.22.camel@ibm-c.pdx.osdl.net>
[not found] ` <20040316180043.441e8150.akpm@osdl.org>
2004-03-17 20:11 ` 2.6.4-mm2 Chris Mason
2004-03-17 20:33 ` 2.6.4-mm2 Andrew Morton
2004-03-17 22:46 ` 2.6.4-mm2 Chris Mason
2004-03-17 23:09 ` 2.6.4-mm2 Andrew Morton
2004-03-17 23:27 ` 2.6.4-mm2 Chris Mason
2004-03-17 23:51 ` 2.6.4-mm2 Andrew Morton
2004-03-18 0:06 ` 2.6.4-mm2 Chris Mason
2004-03-18 0:13 ` 2.6.4-mm2 Andrew Morton
2004-03-18 0:31 ` 2.6.4-mm2 Chris Mason
2004-03-18 0:33 ` 2.6.4-mm2 Andrew Morton
2004-03-18 0:41 ` 2.6.4-mm2 Chris Mason
2004-03-18 1:15 ` 2.6.4-mm2 Daniel McNeil
2004-03-18 17:53 ` 2.6.4-mm2 Daniel McNeil
2004-03-18 18:47 ` 2.6.4-mm2 Chris Mason
2004-03-18 19:10 ` 2.6.4-mm2 Daniel McNeil
2004-03-19 16:49 ` 2.6.5-rc2-mm2 and direct_read_under Daniel McNeil
2004-03-19 17:05 ` 2.6.5-rc1-mm2 " Daniel McNeil
2004-03-21 14:36 ` Chris Mason
2004-03-22 18:10 ` 2.6.5-rc1-mm2 and direct_read_under and wb Daniel McNeil
2004-03-22 18:23 ` Chris Mason
2004-03-22 18:27 ` Chris Mason
2004-03-22 18:35 ` Chris Mason
2004-03-22 18:51 ` Daniel McNeil
2004-03-22 23:13 ` Andrew Morton
2004-03-23 0:51 ` Daniel McNeil
2004-03-23 9:25 ` Andrew Morton
2004-03-23 17:05 ` Daniel McNeil
2004-03-23 17:59 ` Andrew Morton
2004-03-23 21:38 ` Daniel McNeil
2004-03-23 21:47 ` Andrew Morton
2004-03-18 17:37 ` 2.6.4-mm2 markw
2004-03-18 18:06 ` 2.6.4-mm2 Andrew Morton
2004-03-18 18:48 ` 2.6.4-mm2 markw
2004-03-18 19:10 ` 2.6.4-mm2 Chris Mason
2004-03-18 19:27 ` 2.6.4-mm2 Jens Axboe
2004-03-18 23:38 ` 2.6.4-mm2 markw
2004-03-19 7:39 ` 2.6.4-mm2 Jens Axboe
2004-03-19 3:15 ` 2.6.4-mm2 Andrew Morton
2004-03-19 7:39 ` 2.6.4-mm2 Jens Axboe
2004-03-19 7:52 ` 2.6.4-mm2 Andrew Morton
2004-03-19 7:57 ` 2.6.4-mm2 Jens Axboe
2004-03-19 8:19 ` 2.6.4-mm2 Andrew Morton
2004-03-19 8:31 ` 2.6.4-mm2 Jens Axboe
2004-03-19 8:39 ` 2.6.4-mm2 Andrew Morton
2004-03-19 8:48 ` 2.6.4-mm2 Jens Axboe
2004-03-19 9:56 ` 2.6.4-mm2 Miquel van Smoorenburg
2004-03-19 10:00 ` 2.6.4-mm2 Jens Axboe
[not found] ` <20040318194150.4de65049.akpm@osdl.org>
2004-03-20 2:39 ` 2.6.4-mm2 Mark Wong
2004-03-20 2:47 ` 2.6.4-mm2 Mark Wong
2004-03-20 2:50 ` 2.6.4-mm2 Andrew Morton
2004-03-20 2:53 ` 2.6.4-mm2 Mark Wong
2004-03-20 3:52 ` 2.6.4-mm2 Nick Piggin
2004-03-20 4:14 ` 2.6.4-mm2 Andrew Morton
2004-03-20 4:24 ` 2.6.4-mm2 Nick Piggin
2004-03-20 4:26 ` 2.6.4-mm2 Nick Piggin
2004-03-20 21:17 ` 2.6.4-mm2 Martin J. Bligh
2004-03-22 17:19 ` 2.6.4-mm2 Mary Edie Meredith
2004-03-23 0:27 ` 2.6.4-mm2 Andrew Morton
2004-03-23 19:21 ` 2.6.4-mm2 Mary Edie Meredith
2004-03-23 19:32 ` 2.6.4-mm2 Andrew Morton
2004-03-24 0:07 ` 2.6.4-mm2 Mary Edie Meredith
2004-03-30 21:30 ` 2.6.4-mm2 Mary Edie Meredith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040315093256.GS14833@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=akpm@osdl.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjander@embedded.cl \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox