From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: greg@kroah.com, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Driver Core update for 2.6.4
Date: Tue, 16 Mar 2004 01:51:41 -0800 [thread overview]
Message-ID: <20040316015141.062fecff.akpm@osdl.org> (raw)
In-Reply-To: <20040316070409.A28022@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
>
> On Mon, Mar 15, 2004 at 03:59:09PM -0800, Greg KH wrote:
> > ChangeSet 1.1608.84.16, 2004/03/15 14:39:18-08:00, greg@kroah.com
> >
> > kref: add kref structure to kernel tree.
> >
> > Based on the kobject structure, but much smaller and simpler to use.
>
> Didn't everyone who reviewed this say it's useless bloat.
No.
bix:/usr/src/25> wc -l include/linux/kref.h lib/kref.c
32 include/linux/kref.h
60 lib/kref.c
92 total
bix:/usr/src/25> size lib/kref.o
text data bss dec hex filename
368 0 0 368 170 lib/kref.o
> Andi even got
> so far as calling it obsfucation, given that hides simple things behind
> an overly complex and wastefull abstraction.
eh? If there is any argument against this code it is that it is so simple
that the thing which it abstracts is not worth abstracting. But given that
it is so unwasteful, this seems unimportant.
next prev parent reply other threads:[~2004-03-16 9:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 23:55 [BK PATCH] Driver Core update for 2.6.4 Greg KH
2004-03-15 23:59 ` [PATCH] " Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-16 7:04 ` Christoph Hellwig
2004-03-16 9:51 ` Andrew Morton [this message]
[not found] <1AajM-5vw-21@gated-at.bofh.it>
[not found] ` <1Abpq-6Av-1@gated-at.bofh.it>
[not found] ` <1Aj3K-5Fn-9@gated-at.bofh.it>
[not found] ` <1AjwZ-65D-15@gated-at.bofh.it>
2004-03-16 16:14 ` Andi Kleen
2004-03-16 19:40 ` Greg KH
2004-03-17 0:01 ` Andi Kleen
2004-03-19 9:17 ` Jamie Lokier
2004-03-19 11:52 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316015141.062fecff.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox