From: Andi Kleen <ak@suse.de>
To: Nobuhiko Yoshida <n-yoshida@pst.fujitsu.com>
Cc: raybry@sgi.com, linux-kernel@vger.kernel.org,
lse-tech@lists.sourceforge.net, linux-ia64@vger.kernel.org,
Hirokazu Takahashi <taka@valinux.co.jp>
Subject: Re: Hugetlbpages in very large memory machines.......
Date: Tue, 16 Mar 2004 02:54:01 +0100 [thread overview]
Message-ID: <20040316015401.GF9931@wotan.suse.de> (raw)
In-Reply-To: <JP20040316093003.3103921@pst.fujitsu.com>
> + pte = huge_pte_alloc(mm, address);
> + set_huge_pte(mm, vma, page, pte, vma->vm_flags & VM_WRITE);
This looks broken. Another CPU could have raced to the same fault
and already added an PTE here. You have to handle that.
(my i386 version originally had the same problem)
> +/* update_mmu_cache(vma, address, *pte); */
I have not studied low level IA64 VM in detail, but don't you need
some kind of TLB flush here?
-Andi
next prev parent reply other threads:[~2004-03-16 1:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-13 3:44 Hugetlbpages in very large memory machines Ray Bryant
2004-03-13 3:48 ` Andi Kleen
2004-03-13 5:49 ` William Lee Irwin III
2004-03-13 16:10 ` [Lse-tech] " Andi Kleen
2004-03-14 0:05 ` William Lee Irwin III
2004-03-14 5:22 ` Peter Chubb
[not found] ` <844231526.20040313030948@adinet.com.uy>
[not found] ` <20040313061232.GB655@holomorphy.com>
2004-03-13 16:32 ` Re[2]: " Luis Mirabal
2004-03-14 2:45 ` Andrew Morton
2004-03-14 4:06 ` [Lse-tech] " Anton Blanchard
2004-03-17 19:05 ` Andy Whitcroft
2004-03-18 20:25 ` Andrew Morton
2004-03-18 21:22 ` Stephen Smalley
2004-03-18 22:21 ` Andy Whitcroft
2004-03-23 17:30 ` Andy Whitcroft
2004-03-24 17:38 ` Andy Whitcroft
2004-03-14 8:38 ` Ray Bryant
2004-03-14 8:48 ` William Lee Irwin III
2004-03-14 8:57 ` Andrew Morton
2004-03-14 9:02 ` Andrew Morton
2004-03-14 9:07 ` William Lee Irwin III
2004-03-15 6:45 ` Ray Bryant
2004-03-15 23:54 ` William Lee Irwin III
2004-03-13 3:55 ` William Lee Irwin III
2004-03-13 4:56 ` Hirokazu Takahashi
2004-03-16 0:30 ` Nobuhiko Yoshida
2004-03-16 1:54 ` Andi Kleen [this message]
2004-03-16 2:32 ` Hirokazu Takahashi
2004-03-16 3:20 ` Hirokazu Takahashi
2004-03-16 3:15 ` Nobuhiko Yoshida
2004-04-01 9:10 ` Nobuhiko Yoshida
2004-03-15 15:28 ` jlnance
-- strict thread matches above, loose matches on Subject: below --
2004-03-13 3:45 Ray Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316015401.GF9931@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=n-yoshida@pst.fujitsu.com \
--cc=raybry@sgi.com \
--cc=taka@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox