From: William Lee Irwin III <wli@holomorphy.com>
To: Zwane Mwaikambo <zwane@linuxpower.ca>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@osdl.org>,
Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH][2.6-mm] Fix 4G/4G w/ 8k+ stacks
Date: Tue, 16 Mar 2004 02:40:42 -0800 [thread overview]
Message-ID: <20040316104042.GO655@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0403150401310.28447@montezuma.fsmlabs.com>
On Tue, Mar 16, 2004 at 01:35:36AM -0500, Zwane Mwaikambo wrote:
> +#ifdef CONFIG_4KSTACKS
> +#define STACK_PAGE_COUNT (4096/PAGE_SIZE)
> +#else
> +#define STACK_PAGE_COUNT (8192/PAGE_SIZE) /* THREAD_SIZE/PAGE_SIZE */
> +#endif
This looks like it wants to be:
#define STACK_PAGE_COUNT (PAGE_ALIGN(THREAD_SIZE)/PAGE_SIZE)
(There are reasons to want THREAD_SIZE < PAGE_SIZE having to do with
elevating PAGE_SIZE as opposed to shrinking THREAD_SIZE outright.)
It looks like kmap_types.h should inherits PAGE_* from processor.h
which in turn should inherit them from page.h
Did the headers barf on this or something? I can't imagine you didn't
think of it already.
-- wli
next prev parent reply other threads:[~2004-03-16 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-16 6:35 [PATCH][2.6-mm] Fix 4G/4G w/ 8k+ stacks Zwane Mwaikambo
2004-03-16 7:16 ` Ingo Molnar
2004-03-16 10:40 ` William Lee Irwin III [this message]
2004-03-16 17:08 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316104042.GO655@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox