From: Dave Jones <davej@redhat.com>
To: Marc Zyngier <mzyngier@freesurf.fr>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org, akpm@osdl.org,
jgarzik@pobox.com
Subject: Re: [3C509] Fix sysfs leak.
Date: Tue, 16 Mar 2004 14:29:51 +0000 [thread overview]
Message-ID: <20040316142951.GA17958@redhat.com> (raw)
In-Reply-To: <wrp3c88g9xu.fsf@panther.wild-wind.fr.eu.org>
On Tue, Mar 16, 2004 at 03:09:49PM +0100, Marc Zyngier wrote:
> >>>>> "Dave" == Dave Jones <davej@redhat.com> writes:
>
> Dave> Then the probing routine is bogus, it returns 0 when it fails too.
>
> Uh ? el3_eisa_probe looks like it properly returns an error...
>
> Or maybe you call a failure not finding a proper device on the bus ?
The damned bus doesn't even exist. If this is a case that couldn't be
detected, I'd not be complaining, but this is just nonsense having
a driver claim that its found an EISA device, when there aren't even
any EISA slots on the board.
> When the driver registers, the bus may not have been probed yet
> (built-in case). So un-registering the driver when it fails to find a
> proper device is simply wrong with the current implementation.
This happens long after bus initialisation should have already figured
out that the bus doesn't exist. Even if it was left this late, the
eisa registration code should be doing a 'oh, I've not even checked
if I have a bus yet, I'll do it now' before it starts doing completely
bogus things like checking for devices.
The way I see it, EISA bus support is completely horked right now.
Dave
next prev parent reply other threads:[~2004-03-16 14:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 21:47 [3C509] Fix sysfs leak davej
2004-03-16 10:56 ` Marc Zyngier
2004-03-16 13:46 ` Dave Jones
2004-03-16 14:09 ` Marc Zyngier
2004-03-16 14:29 ` Dave Jones [this message]
2004-03-16 15:05 ` Marc Zyngier
2004-03-16 15:30 ` Dave Jones
2004-03-16 16:05 ` Marc Zyngier
2004-03-16 16:16 ` Dave Jones
2004-03-16 15:58 ` Richard B. Johnson
2004-03-19 16:36 ` Vojtech Pavlik
2004-03-16 16:06 ` Jeff Garzik
2004-03-16 16:13 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316142951.GA17958@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mzyngier@freesurf.fr \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox