From: Dave Jones <davej@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Marc Zyngier <mzyngier@freesurf.fr>,
linux-kernel@vger.kernel.org, torvalds@osdl.org, akpm@osdl.org
Subject: Re: [3C509] Fix sysfs leak.
Date: Tue, 16 Mar 2004 16:13:00 +0000 [thread overview]
Message-ID: <20040316161300.GC17958@redhat.com> (raw)
In-Reply-To: <405725F2.7090701@pobox.com>
On Tue, Mar 16, 2004 at 11:06:10AM -0500, Jeff Garzik wrote:
> Dave Jones wrote:
> >On Tue, Mar 16, 2004 at 11:56:37AM +0100, Marc Zyngier wrote:
> > > >>>>> "davej" == davej <davej@redhat.com> writes:
> > >
> > > davej> #ifdef CONFIG_EISA
> > > davej> - if (eisa_driver_register (&el3_eisa_driver) < 0) {
> > > davej> + if (eisa_driver_register (&el3_eisa_driver) <= 0) {
> > > davej> eisa_driver_unregister (&el3_eisa_driver);
> > > davej> }
> > > davej> #endif
> > >
> > > This is bogus. eisa_driver_register returns 0 when it *succeeds*.
> >
> >Then the probing routine is bogus, it returns 0 when it fails too.
>
> No, for the hotplug case the API allows registration to succeed, then
> probing calls the ->init_one function later.
Not when the module buggers off afterwards it doesn't.
->init_one points to lala land at that point.
Dave
prev parent reply other threads:[~2004-03-16 16:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 21:47 [3C509] Fix sysfs leak davej
2004-03-16 10:56 ` Marc Zyngier
2004-03-16 13:46 ` Dave Jones
2004-03-16 14:09 ` Marc Zyngier
2004-03-16 14:29 ` Dave Jones
2004-03-16 15:05 ` Marc Zyngier
2004-03-16 15:30 ` Dave Jones
2004-03-16 16:05 ` Marc Zyngier
2004-03-16 16:16 ` Dave Jones
2004-03-16 15:58 ` Richard B. Johnson
2004-03-19 16:36 ` Vojtech Pavlik
2004-03-16 16:06 ` Jeff Garzik
2004-03-16 16:13 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316161300.GC17958@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mzyngier@freesurf.fr \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox