public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Michael Frank <mhf@linuxmail.org>
Cc: kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.x atkbd.c moaning
Date: Thu, 18 Mar 2004 23:01:14 +1100	[thread overview]
Message-ID: <20040318120114.GN28212@krispykreme> (raw)
In-Reply-To: <opr41z9zel4evsfm@smtp.pacific.net.th>


> Why is this and should I investigate further?
..
 
> mice: PS/2 mouse device common for all mice
> serio: i8042 AUX port at 0x60,0x64 irq 12
> input: ImExPS/2 Generic Explorer Mouse on isa0060/serio1
> serio: i8042 KBD port at 0x60,0x64 irq 1
> input: AT Translated Set 2 keyboard on isa0060/serio0
> atkbd.c: Unknown key released (translated set 2, code 0x7a on isa0060/serio0).

Did this happen recently? If so, does backing out the following patch help?

Anton


# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/03/03 15:14:01+01:00 vojtech@suse.cz 
#   input: i8042.c:
#     Assume the chip always is in XLATE mode, even when it doesn't
#     have the XLATE bit set - apparently IBM PS/2 model 70 behaves
#     this way.
# 
# drivers/input/serio/i8042.c
#   2004/03/03 15:13:56+01:00 vojtech@suse.cz +0 -8
#   input: i8042.c:
#     Assume the chip always is in XLATE mode, even when it doesn't
#     have the XLATE bit set - apparently IBM PS/2 model 70 behaves
#     this way.
# 
diff -Nru a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
--- a/drivers/input/serio/i8042.c	Thu Mar 18 15:06:59 2004
+++ b/drivers/input/serio/i8042.c	Thu Mar 18 15:06:59 2004
@@ -722,14 +722,6 @@
 	}
 
 /*
- * If the chip is configured into nontranslated mode by the BIOS, don't
- * bother enabling translating and be happy.
- */
-
-	if (~i8042_ctr & I8042_CTR_XLATE)
-		i8042_direct = 1;
-
-/*
  * Set nontranslated mode for the kbd interface if requested by an option.
  * After this the kbd interface becomes a simple serial in/out, like the aux
  * interface is. We don't do this by default, since it can confuse notebook

  reply	other threads:[~2004-03-18 12:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-18 10:47 2.6.x atkbd.c moaning Michael Frank
2004-03-18 12:01 ` Anton Blanchard [this message]
2004-03-18 17:03   ` Michael Frank
2004-03-18 19:14     ` Michael Frank
2004-03-18 19:34       ` Michael Frank
2004-03-18 19:58       ` Vojtech Pavlik
2004-03-18 20:46         ` Michael Frank
2004-03-18 21:07           ` Vojtech Pavlik
2004-03-18 21:50             ` Michael Frank
2004-03-18 21:58               ` Michael Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040318120114.GN28212@krispykreme \
    --to=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhf@linuxmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox