From: Vojtech Pavlik <vojtech@suse.cz>
To: "Richard B. Johnson" <root@chaos.analogic.com>
Cc: Dave Jones <davej@redhat.com>,
Marc Zyngier <mzyngier@freesurf.fr>,
Linux kernel <linux-kernel@vger.kernel.org>,
torvalds@osdl.org, akpm@osdl.org, jgarzik@pobox.com
Subject: Re: [3C509] Fix sysfs leak.
Date: Fri, 19 Mar 2004 17:36:50 +0100 [thread overview]
Message-ID: <20040319163650.GA4458@ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.53.0403161053040.6499@chaos>
On Tue, Mar 16, 2004 at 10:58:08AM -0500, Richard B. Johnson wrote:
> On Tue, 16 Mar 2004, Dave Jones wrote:
>
> > On Tue, Mar 16, 2004 at 03:09:49PM +0100, Marc Zyngier wrote:
> > > >>>>> "Dave" == Dave Jones <davej@redhat.com> writes:
> > >
> > > Dave> Then the probing routine is bogus, it returns 0 when it fails too.
> > >
> > > Uh ? el3_eisa_probe looks like it properly returns an error...
> > >
> > > Or maybe you call a failure not finding a proper device on the bus ?
> >
> > The damned bus doesn't even exist. If this is a case that couldn't be
> > detected, I'd not be complaining, but this is just nonsense having
> > a driver claim that its found an EISA device, when there aren't even
> > any EISA slots on the board.
>
> There is no way that any software knows about an EISA bus. It
> only knows that there is some device at some port. Since a 3c503
> was built to go into an 8-bit EISA slot, if one is found it
> is assumed to be in such a slot on the EISA bus!
>
> So, if the device doesn't exist there is a problem with the
> detection method for the device, not a detection method for
> a bus because the bus can't be detected at all.
3c503 in EISA? 8-bit EISA? I think you mean ISA ...
EISA has slot information available, as far as I know, and device
identifiers and ... and is a 32-bit bus.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2004-03-19 16:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 21:47 [3C509] Fix sysfs leak davej
2004-03-16 10:56 ` Marc Zyngier
2004-03-16 13:46 ` Dave Jones
2004-03-16 14:09 ` Marc Zyngier
2004-03-16 14:29 ` Dave Jones
2004-03-16 15:05 ` Marc Zyngier
2004-03-16 15:30 ` Dave Jones
2004-03-16 16:05 ` Marc Zyngier
2004-03-16 16:16 ` Dave Jones
2004-03-16 15:58 ` Richard B. Johnson
2004-03-19 16:36 ` Vojtech Pavlik [this message]
2004-03-16 16:06 ` Jeff Garzik
2004-03-16 16:13 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040319163650.GA4458@ucw.cz \
--to=vojtech@suse.cz \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mzyngier@freesurf.fr \
--cc=root@chaos.analogic.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox