From: Greg KH <greg@kroah.com>
To: Marc-Christian Petersen <m.c.p@wolk-project.de>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-usb-users@lists.sourceforge.net
Subject: Re: [PATCH 2.6.5-rc2] CAN-2004-0075 still valid for 2.6?
Date: Sat, 20 Mar 2004 12:16:36 -0800 [thread overview]
Message-ID: <20040320201636.GC14667@kroah.com> (raw)
In-Reply-To: <200403202059.33039@WOLK>
On Sat, Mar 20, 2004 at 08:59:33PM +0100, Marc-Christian Petersen wrote:
> Hi Greg,
>
> seems $subject is still valid for 2.6, no? - 2.4 got a fix 11 weeks ago.
>
> See this:
> http://linux.bkbits.net:8080/linux-2.4/diffs/drivers/usb/vicam.c@1.15?nav=index.html|
> src/|src/drivers|src/drivers/usb|hist/drivers/usb/vicam.c
>
> Please apply.
>
> ciao, Marc
> # drivers/usb/media/vicam.c | 13 ++++++++++---
> # 1 files changed, 10 insertions(+), 3 deletions(-)
>
> diff -urN linux-old/drivers/usb/media/vicam.c linux-wolk-for-2.6drivers/usb/media/vicam.c
> --- linux-old/drivers/usb/media/vicam.c 2003-11-28 10:26:20.000000000 -0800
> +++ linux-wolk-for-2.6drivers/usb/media/vicam.c 2004-01-15 12:10:23.000000000 -0800
> @@ -653,12 +653,19 @@
> case VIDIOCSWIN:
> {
>
> - struct video_window *vw = (struct video_window *) arg;
> - DBG("VIDIOCSWIN %d x %d\n", vw->width, vw->height);
> + struct video_window vw;
>
> - if ( vw->width != 320 || vw->height != 240 )
> + if (copy_from_user(&vw, arg, sizeof(vw)))
> + {
Care to implement proper coding style here?
And for some reason I thought this was already fixed in 2.6... guess
not.
thanks,
greg k-h
prev parent reply other threads:[~2004-03-20 20:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-20 19:59 [PATCH 2.6.5-rc2] CAN-2004-0075 still valid for 2.6? Marc-Christian Petersen
2004-03-20 20:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040320201636.GC14667@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-users@lists.sourceforge.net \
--cc=m.c.p@wolk-project.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox