* [PATCH 2.6.5-rc2] CAN-2004-0075 still valid for 2.6?
@ 2004-03-20 19:59 Marc-Christian Petersen
2004-03-20 20:16 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Marc-Christian Petersen @ 2004-03-20 19:59 UTC (permalink / raw)
To: lkml; +Cc: linux-usb-users, Greg Kroah-Hartman
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
Hi Greg,
seems $subject is still valid for 2.6, no? - 2.4 got a fix 11 weeks ago.
See this:
http://linux.bkbits.net:8080/linux-2.4/diffs/drivers/usb/vicam.c@1.15?nav=index.html|
src/|src/drivers|src/drivers/usb|hist/drivers/usb/vicam.c
Please apply.
ciao, Marc
[-- Attachment #2: CAN-2004-0075-usb-vicam.patch --]
[-- Type: text/x-diff, Size: 840 bytes --]
# drivers/usb/media/vicam.c | 13 ++++++++++---
# 1 files changed, 10 insertions(+), 3 deletions(-)
diff -urN linux-old/drivers/usb/media/vicam.c linux-wolk-for-2.6drivers/usb/media/vicam.c
--- linux-old/drivers/usb/media/vicam.c 2003-11-28 10:26:20.000000000 -0800
+++ linux-wolk-for-2.6drivers/usb/media/vicam.c 2004-01-15 12:10:23.000000000 -0800
@@ -653,12 +653,19 @@
case VIDIOCSWIN:
{
- struct video_window *vw = (struct video_window *) arg;
- DBG("VIDIOCSWIN %d x %d\n", vw->width, vw->height);
+ struct video_window vw;
- if ( vw->width != 320 || vw->height != 240 )
+ if (copy_from_user(&vw, arg, sizeof(vw)))
+ {
retval = -EFAULT;
+ break;
+ }
+
+ DBG("VIDIOCSWIN %d x %d\n", vw->width, vw->height);
+ if ( vw.width != 320 || vw.height != 240 )
+ retval = -EFAULT;
+
break;
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 2.6.5-rc2] CAN-2004-0075 still valid for 2.6?
2004-03-20 19:59 [PATCH 2.6.5-rc2] CAN-2004-0075 still valid for 2.6? Marc-Christian Petersen
@ 2004-03-20 20:16 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2004-03-20 20:16 UTC (permalink / raw)
To: Marc-Christian Petersen; +Cc: lkml, linux-usb-users
On Sat, Mar 20, 2004 at 08:59:33PM +0100, Marc-Christian Petersen wrote:
> Hi Greg,
>
> seems $subject is still valid for 2.6, no? - 2.4 got a fix 11 weeks ago.
>
> See this:
> http://linux.bkbits.net:8080/linux-2.4/diffs/drivers/usb/vicam.c@1.15?nav=index.html|
> src/|src/drivers|src/drivers/usb|hist/drivers/usb/vicam.c
>
> Please apply.
>
> ciao, Marc
> # drivers/usb/media/vicam.c | 13 ++++++++++---
> # 1 files changed, 10 insertions(+), 3 deletions(-)
>
> diff -urN linux-old/drivers/usb/media/vicam.c linux-wolk-for-2.6drivers/usb/media/vicam.c
> --- linux-old/drivers/usb/media/vicam.c 2003-11-28 10:26:20.000000000 -0800
> +++ linux-wolk-for-2.6drivers/usb/media/vicam.c 2004-01-15 12:10:23.000000000 -0800
> @@ -653,12 +653,19 @@
> case VIDIOCSWIN:
> {
>
> - struct video_window *vw = (struct video_window *) arg;
> - DBG("VIDIOCSWIN %d x %d\n", vw->width, vw->height);
> + struct video_window vw;
>
> - if ( vw->width != 320 || vw->height != 240 )
> + if (copy_from_user(&vw, arg, sizeof(vw)))
> + {
Care to implement proper coding style here?
And for some reason I thought this was already fixed in 2.6... guess
not.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-03-20 20:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-20 19:59 [PATCH 2.6.5-rc2] CAN-2004-0075 still valid for 2.6? Marc-Christian Petersen
2004-03-20 20:16 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox