From: Andrew Morton <akpm@osdl.org>
To: Andrea Arcangeli <andrea@suse.de>
Cc: hugh@veritas.com, linux-kernel@vger.kernel.org
Subject: Re: VMA_MERGING_FIXUP and patch
Date: Mon, 22 Mar 2004 12:33:52 -0800 [thread overview]
Message-ID: <20040322123352.660a2edc.akpm@osdl.org> (raw)
In-Reply-To: <20040322200505.GB22639@dualathlon.random>
Andrea Arcangeli <andrea@suse.de> wrote:
>
> On Mon, Mar 22, 2004 at 11:57:34AM -0800, Andrew Morton wrote:
> > set_page_dirty() takes ->tree_lock and inode_lock. tree_lock surely is OK
> > and while I cannot think of any deadlocks which could occur with taking
> > inode_lock inside the rmap lock, it doesn't sound very nice.
> >
> > It would of course be best if we could avoid adding a new ranking
> > relationship between these locks.
>
> agreed. the inode_lock especially is more a vfs thing than a mm thing,
> so it lives quite far away.
Alas, inode_lock can be taken inside page_table_lock, in zap_pte_range().
That set_page_dirty() in there is the nastiest part of the MM locking.
prev parent reply other threads:[~2004-03-22 20:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-22 17:05 VMA_MERGING_FIXUP and patch Hugh Dickins
2004-03-22 17:52 ` Andrea Arcangeli
2004-03-22 19:02 ` Hugh Dickins
2004-03-22 19:58 ` Andrea Arcangeli
2004-03-23 21:44 ` nonlinear swapping w/o pte_chains [Re: VMA_MERGING_FIXUP and patch] Andrea Arcangeli
2004-03-24 2:35 ` Andrea Arcangeli
2004-03-24 4:38 ` Andrea Arcangeli
2004-03-24 10:12 ` Hugh Dickins
2004-03-24 12:18 ` Hugh Dickins
2004-03-24 14:47 ` Andrea Arcangeli
2004-03-24 14:37 ` Andrea Arcangeli
2004-03-24 18:42 ` Andrea Arcangeli
2004-03-22 19:57 ` VMA_MERGING_FIXUP and patch Andrew Morton
2004-03-22 20:05 ` Andrea Arcangeli
2004-03-22 20:33 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040322123352.660a2edc.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox