From: Lars Marowsky-Bree <lmb@suse.de>
To: Marcus Meissner <meissner@suse.de>, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>
Subject: Re: PATCH: siginfo -> si_band is long
Date: Wed, 24 Mar 2004 22:43:55 +0100 [thread overview]
Message-ID: <20040324214355.GZ2095@marowsky-bree.de> (raw)
In-Reply-To: <20040324135737.GB9355@suse.de>
On 2004-03-24T14:57:37,
Marcus Meissner <meissner@suse.de> said:
Hi Andrew, the patch looks good to me (I originally stumbled across this
when debugging an application trying to use SIGIO, which is currently
broken on ppc64).
Could you please pick it up?
s390x, sparc64 might also be affected, btw.
Why are all these archs not using the asm-generic/siginfo.h anyway?
*sigh*. Oh well.
> Hi,
>
> After discussion on the glibc list the result was that
> si_band is "long int" according to POSIX:
>
> http://www.opengroup.org/onlinepubs/007904975/basedefs/signal.h.html
>
> Ulrich Drepper refused a patch to fix glibc due to this reason:
> http://sources.redhat.com/ml/libc-alpha/2004-03/msg00254.html
>
> so here is the patch to fix it in the kernel.
>
> ppc64 and s390x were broken before and are fixed by this patch too.
>
> Please apply.
>
> Ciao, Marcus
>
> --- linux-2.6.4/include/asm-generic/siginfo.h.xx 2004-03-24 14:44:23.000000000 +0100
> +++ linux-2.6.4/include/asm-generic/siginfo.h 2004-03-24 14:44:36.000000000 +0100
> @@ -27,7 +27,7 @@
> #endif
>
> #ifndef __ARCH_SI_BAND_T
> -#define __ARCH_SI_BAND_T int
> +#define __ARCH_SI_BAND_T long int
> #endif
>
> #ifndef HAVE_ARCH_SIGINFO_T
> --- linux-2.6.4/include/asm-x86_64/siginfo.h.xx 2004-03-24 14:45:26.000000000 +0100
> +++ linux-2.6.4/include/asm-x86_64/siginfo.h 2004-03-24 14:45:34.000000000 +0100
> @@ -3,8 +3,6 @@
>
> #define __ARCH_SI_PREAMBLE_SIZE (4 * sizeof(int))
>
> -#define __ARCH_SI_BAND_T long
> -
> #define SIGEV_PAD_SIZE ((SIGEV_MAX_SIZE/sizeof(int)) - 4)
>
> #include <asm-generic/siginfo.h>
>
> Ciao, Marcus
Sincerely,
Lars Marowsky-Brée <lmb@suse.de>
--
High Availability & Clustering \ ever tried. ever failed. no matter.
SUSE Labs | try again. fail again. fail better.
Research & Development, SUSE LINUX AG \ -- Samuel Beckett
prev parent reply other threads:[~2004-03-24 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-24 13:57 PATCH: siginfo -> si_band is long Marcus Meissner
2004-03-24 21:43 ` Lars Marowsky-Bree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040324214355.GZ2095@marowsky-bree.de \
--to=lmb@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meissner@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox