Re: [Swsusp-devel] (no subject)

[Marc Lehmann <pcg@schmorp.de>]

On Mon, Mar 22, 2004 at 05:18:57PM +0800, Michael Frank <mhf@linuxmail.org> wrote:
> Also, as Pavel mentioned, LZF code should be put in /lib and cleaned up. 

I fully agree. Unfortunately, I have about zero time for any such project
in the foreseeable future (It'd need more time since my knowledge about
integration issues is extremely scarce, and I am swamped with other work).

The code in the kernel required a few features not available with earlier
lzf releases (e.g. passing the the hash table via args instead of
allocating it on the stack).

The standard 1.3 release is configurable via defines in this respect
(-DAVOID_ERRNO -DLZF_STATE_ARG), and would be better suited for inclusion
in the kernel (the code would be byte-identical in the userspace and
kernel version), but making a patch would require some testing, to make
sure the new code compiles etc.

Also, as used in software-suspend2, the user must #define symbols (see
the beginning of kernel/power/lzfcompress.c) and include the c files
directly. When making them library functions one would need to choose
a reasonable default. Copying lzfP.h into include/linux and editing it
should be enough, though.

-- 
      -----==-                                             |
      ----==-- _                                           |
      ---==---(_)__  __ ____  __       Marc Lehmann      +--
      --==---/ / _ \/ // /\ \/ /       pcg@goof.com      |e|
      -=====/_/_//_/\_,_/ /_/\_\       XX11-RIPE         --+
    The choice of a GNU generation                       |
                                                         |