From: Tom Rini <trini@kernel.crashing.org>
To: Meelis Roos <mroos@linux.ee>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] asm-ppc/elf.h warning
Date: Fri, 26 Mar 2004 11:19:45 -0700 [thread overview]
Message-ID: <20040326181945.GA20819@smtp.west.cox.net> (raw)
In-Reply-To: <Pine.GSO.4.44.0403261956350.2460-100000@math.ut.ee>
On Fri, Mar 26, 2004 at 08:00:06PM +0200, Meelis Roos wrote:
> > Can you try just removing <linux/elf.h> from everything in
> > arch/ppc/boot/ ?
>
> elf.h include is present in arch/ppc/boot/simple/misc.c and
> arch/ppc/boot/simple/misc-embedded.c. The first one caused my warning
> and the include can be safely removed from there. The other file is not
> used in my config (prep) but I did try to compile it with elf.h include
> removed (make arch/ppc/boot/simple/misc-embedded.o) and it failed. So
> here is the patch against arch/ppc/boot/simple/misc.c.
Ok, I'll look into that myself.
> Nevertheless,
> asm-ppc/elf.h can not be included by itself without a warning about
> struct task_struct - is this a problem or not?
It depends on if (a) other arches have a task_struct-needing extern in
this file and (b) what do they do? There's at least a few #includes
with implicit #include requirements out there, i _think_.
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2004-03-26 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-26 17:33 [PATCH] asm-ppc/elf.h warning Meelis Roos
2004-03-26 17:43 ` Tom Rini
2004-03-26 18:00 ` Meelis Roos
2004-03-26 18:19 ` Tom Rini [this message]
2004-03-26 21:40 ` Greg Weeks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040326181945.GA20819@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox