* whiteheat USB serial compile failure on PPC (2.6)
@ 2004-03-18 10:06 Meelis Roos
2004-03-19 1:00 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Meelis Roos @ 2004-03-18 10:06 UTC (permalink / raw)
To: linux-kernel
Whiteheat USB serial driver doesn't compile on PPC in 2.6 (in fact,
hasn't compiled fo some time):
drivers/usb/serial/whiteheat.c: In function `firm_setup_port':
drivers/usb/serial/whiteheat.c:1225: error: `CMSPAR' undeclared (first use in this function)
drivers/usb/serial/whiteheat.c:1225: error: (Each undeclared identifier is reported only once
drivers/usb/serial/whiteheat.c:1225: error: for each function it appears in.)
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: whiteheat USB serial compile failure on PPC (2.6)
2004-03-18 10:06 whiteheat USB serial compile failure on PPC (2.6) Meelis Roos
@ 2004-03-19 1:00 ` Greg KH
2004-03-19 1:32 ` Paul Mackerras
2004-03-26 12:36 ` Meelis Roos
0 siblings, 2 replies; 5+ messages in thread
From: Greg KH @ 2004-03-19 1:00 UTC (permalink / raw)
To: Meelis Roos; +Cc: linux-kernel
On Thu, Mar 18, 2004 at 12:06:38PM +0200, Meelis Roos wrote:
> Whiteheat USB serial driver doesn't compile on PPC in 2.6 (in fact,
> hasn't compiled fo some time):
>
> drivers/usb/serial/whiteheat.c: In function `firm_setup_port':
> drivers/usb/serial/whiteheat.c:1225: error: `CMSPAR' undeclared (first use in this function)
> drivers/usb/serial/whiteheat.c:1225: error: (Each undeclared identifier is reported only once
> drivers/usb/serial/whiteheat.c:1225: error: for each function it appears in.)
Bah, looks like PPC doesn't ever define CMSPAR :(
How about adding something like:
#ifndef CMSPAR
#define CMSPAR 0
#endif
To the beginning of the driver like the cdc-acm.c driver does? If that
works, care to send me a patch?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: whiteheat USB serial compile failure on PPC (2.6)
2004-03-19 1:00 ` Greg KH
@ 2004-03-19 1:32 ` Paul Mackerras
2004-03-26 12:36 ` Meelis Roos
1 sibling, 0 replies; 5+ messages in thread
From: Paul Mackerras @ 2004-03-19 1:32 UTC (permalink / raw)
To: Greg KH; +Cc: Meelis Roos, linux-kernel
Greg KH writes:
> Bah, looks like PPC doesn't ever define CMSPAR :(
What the heck is CMSPAR? Is it in POSIX?
Paul.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: whiteheat USB serial compile failure on PPC (2.6)
2004-03-19 1:00 ` Greg KH
2004-03-19 1:32 ` Paul Mackerras
@ 2004-03-26 12:36 ` Meelis Roos
2004-03-26 20:30 ` Greg KH
1 sibling, 1 reply; 5+ messages in thread
From: Meelis Roos @ 2004-03-26 12:36 UTC (permalink / raw)
To: Greg KH; +Cc: Linux Kernel list
> Bah, looks like PPC doesn't ever define CMSPAR :(
>
> How about adding something like:
> #ifndef CMSPAR
> #define CMSPAR 0
> #endif
> To the beginning of the driver like the cdc-acm.c driver does? If that
> works, care to send me a patch?
Yes, it compiles.
===== drivers/usb/serial/whiteheat.c 1.43 vs edited =====
--- 1.43/drivers/usb/serial/whiteheat.c Fri Jan 23 17:55:41 2004
+++ edited/drivers/usb/serial/whiteheat.c Fri Mar 26 14:10:26 2004
@@ -91,6 +91,10 @@
#include "whiteheat_fw.h" /* firmware for the ConnectTech WhiteHEAT device */
#include "whiteheat.h" /* WhiteHEAT specific commands */
+#ifndef CMSPAR
+#define CMSPAR 0
+#endif
+
/*
* Version Information
*/
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: whiteheat USB serial compile failure on PPC (2.6)
2004-03-26 12:36 ` Meelis Roos
@ 2004-03-26 20:30 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2004-03-26 20:30 UTC (permalink / raw)
To: Meelis Roos; +Cc: Linux Kernel list
On Fri, Mar 26, 2004 at 02:36:00PM +0200, Meelis Roos wrote:
> > Bah, looks like PPC doesn't ever define CMSPAR :(
> >
> > How about adding something like:
> > #ifndef CMSPAR
> > #define CMSPAR 0
> > #endif
> > To the beginning of the driver like the cdc-acm.c driver does? If that
> > works, care to send me a patch?
>
> Yes, it compiles.
Applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-03-26 20:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-18 10:06 whiteheat USB serial compile failure on PPC (2.6) Meelis Roos
2004-03-19 1:00 ` Greg KH
2004-03-19 1:32 ` Paul Mackerras
2004-03-26 12:36 ` Meelis Roos
2004-03-26 20:30 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox