public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy TARREAU <willy@w.ods.org>
To: Chris Wedgwood <cw@f00f.org>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	linux-kernel@vger.kernel.org, chas@cmf.nrl.navy.mil
Subject: Re: [PATCH-2.4.26] ATM cleanup
Date: Sun, 28 Mar 2004 15:08:11 +0200	[thread overview]
Message-ID: <20040328130811.GA7345@pcw.home.local> (raw)
In-Reply-To: <20040328130317.GA8775@dingdong.cryptoapps.com>

On Sun, Mar 28, 2004 at 05:03:17AM -0800, Chris Wedgwood wrote:
> On Sun, Mar 28, 2004 at 02:58:52PM +0200, Willy TARREAU wrote:
> 
> > +++ ./net/atm/mpoa_proc.c	Sun Mar 28 14:52:34 2004
> > @@ -102,7 +102,7 @@
> >  			     size_t count, loff_t *pos){
> >          unsigned long page = 0;
> >  	unsigned char *temp;
> > -        ssize_t length  = 0;
> > +        int length  = 0;
> >  	int i = 0;
> >  	struct mpoa_client *mpc = mpcs;
> >  	in_cache_entry *in_entry;
> 
> no tabs?

Good catch, it seems there are many lines without tabs in this file,
but I don't want to re-indent all the file. At least, the following
patch fixes makes it better for the concerned function.

Cheers,
Willy


--- ./net/atm/mpoa_proc.c.orig	Sun Mar 28 15:04:17 2004
+++ ./net/atm/mpoa_proc.c	Sun Mar 28 15:06:25 2004
@@ -100,9 +100,9 @@
  */
 static ssize_t proc_mpc_read(struct file *file, char *buff,
 			     size_t count, loff_t *pos){
-        unsigned long page = 0;
+	unsigned long page = 0;
 	unsigned char *temp;
-        ssize_t length  = 0;
+	int length  = 0;
 	int i = 0;
 	struct mpoa_client *mpc = mpcs;
 	in_cache_entry *in_entry;


  reply	other threads:[~2004-03-28 13:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-28  4:26 Linux 2.4.26-rc1 Marcelo Tosatti
2004-03-28 11:47 ` Willy TARREAU
2004-03-28 11:54 ` [PATCH-2.4.26] ip6tables cleanup Willy TARREAU
2004-03-28 19:27   ` Peter Osterlund
2004-03-28 20:09     ` Willy TARREAU
2004-03-28 20:33       ` David S. Miller
2004-03-28 22:38         ` Willy TARREAU
2004-03-28 23:00           ` David S. Miller
2004-03-28 20:16     ` David S. Miller
2004-03-28 11:57 ` [PATCH-2.4.26] cmpci cleanup Willy TARREAU
2004-03-29 12:19   ` Marcelo Tosatti
2004-03-28 12:12 ` [PATCH-2.4.26] smbfs cleanup Willy TARREAU
2004-03-28 12:15 ` [PATCH-2.4.26] sddr09 cleanup Willy TARREAU
2004-03-28 12:18   ` Willy TARREAU
2004-03-28 12:21 ` [PATCH-2.4.26] drm/radeon_mem cleanup Willy TARREAU
2004-03-28 12:24 ` [PATCH-2.4.26] cardbus cleanup Willy TARREAU
2004-03-28 12:40 ` Linux 2.4.26-rc1 => Alpha warnings Willy TARREAU
2004-03-28 16:34   ` Ivan Kokshaysky
2004-03-28 12:58 ` [PATCH-2.4.26] ATM cleanup Willy TARREAU
2004-03-28 13:03   ` Chris Wedgwood
2004-03-28 13:08     ` Willy TARREAU [this message]
2004-03-30 17:44       ` chas williams (contractor)
2004-03-31  3:18         ` David S. Miller
2004-03-28 13:38 ` [PATCH-2.4.26] AGPGART cleanup Willy TARREAU
2004-03-28 15:24 ` Linux 2.4.26-rc1 Arkadiusz Miskiewicz
2004-03-28 19:11 ` Peter Osterlund
2004-03-28 20:41   ` Frédéric L. W. Meunier
2004-04-01  0:47   ` Linux 2.4.26-rc1 - SCTP 'make xconfig' issue Sridhar Samudrala
2004-04-01  5:24     ` Peter Osterlund
2004-04-01  7:05     ` David S. Miller
2004-04-01  7:29       ` Sridhar Samudrala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040328130811.GA7345@pcw.home.local \
    --to=willy@w.ods.org \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=cw@f00f.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox