[PATCH 2.6]: suspend to disk only available if non-modular IDE

[PATCH 2.6]: suspend to disk only available if non-modular IDE

[Arkadiusz Miskiewicz]

Hi,

resume from disk doesn't work when using modular IDE so this patch disables
this in config:

--- kernel/power/Kconfig~       2004-03-28 21:32:03.198944320 +0200
+++ kernel/power/Kconfig        2004-03-28 21:32:25.988479784 +0200
@@ -44,7 +44,7 @@

 config PM_DISK
        bool "Suspend-to-Disk Support"
-       depends on PM && SWAP
+       depends on PM && SWAP && IDE=y && BLK_DEV_IDEDISK=y
        ---help---
          Suspend-to-disk is a power management state in which the contents
          of memory are stored on disk and the entire system is shut down or

Info here:
http://groups.google.com/groups?selm=1BdIH-5WB-17%40gated-at.bofh.it&oe=UTF-8&output=gplain
-- 
Arkadiusz Miśkiewicz     CS at FoE, Wroclaw University of Technology
arekm.pld-linux.org, 1024/3DB19BBD, JID: arekm.jabber.org, PLD/Linux

Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

[Nigel Cunningham]

Applied to 2.4 and 2.6.

Thanks and regards,

Nigel

On Mon, 2004-03-29 at 07:36, Arkadiusz Miskiewicz wrote:
> Hi,
> 
> resume from disk doesn't work when using modular IDE so this patch disables
> this in config:
> 
> --- kernel/power/Kconfig~       2004-03-28 21:32:03.198944320 +0200
> +++ kernel/power/Kconfig        2004-03-28 21:32:25.988479784 +0200
> @@ -44,7 +44,7 @@
> 
>  config PM_DISK
>         bool "Suspend-to-Disk Support"
> -       depends on PM && SWAP
> +       depends on PM && SWAP && IDE=y && BLK_DEV_IDEDISK=y
>         ---help---
>           Suspend-to-disk is a power management state in which the contents
>           of memory are stored on disk and the entire system is shut down or
> 
> Info here:
> http://groups.google.com/groups?selm=1BdIH-5WB-17%40gated-at.bofh.it&oe=UTF-8&output=gplain
-- 
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6253 0250 (home)

Evolution (n): A hypothetical process whereby infinitely improbable events occur 
with alarming frequency, order arises from chaos, and no one is given credit.

Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

[Nigel Cunningham]

Oh.. should have said... "Applied to 2.4 and 2.6 suspend2 trees."

Nigel

On Mon, 2004-03-29 at 11:37, Nigel Cunningham wrote:
> Applied to 2.4 and 2.6.
> 
> Thanks and regards,
> 
> Nigel
> 
> On Mon, 2004-03-29 at 07:36, Arkadiusz Miskiewicz wrote:
> > Hi,
> > 
> > resume from disk doesn't work when using modular IDE so this patch disables
> > this in config:
> > 
> > --- kernel/power/Kconfig~       2004-03-28 21:32:03.198944320 +0200
> > +++ kernel/power/Kconfig        2004-03-28 21:32:25.988479784 +0200
> > @@ -44,7 +44,7 @@
> > 
> >  config PM_DISK
> >         bool "Suspend-to-Disk Support"
> > -       depends on PM && SWAP
> > +       depends on PM && SWAP && IDE=y && BLK_DEV_IDEDISK=y
> >         ---help---
> >           Suspend-to-disk is a power management state in which the contents
> >           of memory are stored on disk and the entire system is shut down or
> > 
> > Info here:
> > http://groups.google.com/groups?selm=1BdIH-5WB-17%40gated-at.bofh.it&oe=UTF-8&output=gplain
-- 
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6253 0250 (home)

Evolution (n): A hypothetical process whereby infinitely improbable events occur 
with alarming frequency, order arises from chaos, and no one is given credit.

Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

[Andreas Jellinghaus]

so suspend to disk does not work with scsi?

>> > -       depends on PM && SWAP
>> > +       depends on PM && SWAP && IDE=y && BLK_DEV_IDEDISK=y

implies IDE is needed.

btw: would it be somehow possible to resume after initrd phase?
or some other idea how a generic kernel with modules in the initrd
could use suspend to disk? or a laptop where the initrd is needed
to setup a dm-crypt volume with the right decrypton key?

Regards, Andreas

Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

[Nigel Cunningham]

Hi.

On Tue, 2004-03-30 at 07:34, Andreas Jellinghaus wrote:
> so suspend to disk does not work with scsi?
> 
> >> > -       depends on PM && SWAP
> >> > +       depends on PM && SWAP && IDE=y && BLK_DEV_IDEDISK=y
> 
> implies IDE is needed.

It is at the moment, I'm afraid. I'm hoping to get SCSI support for
suspend2 finished shortly. I did suspend a OSDL machine to SCSI in
January, but the driver lacked the power management that I needed to
reload the second half of the image and thereby be sure all was okay.

> btw: would it be somehow possible to resume after initrd phase?
> or some other idea how a generic kernel with modules in the initrd
> could use suspend to disk? or a laptop where the initrd is needed
> to setup a dm-crypt volume with the right decrypton key?

That should be doable, provided that the initrd doesn't mount anything.
Decryption is 'interesting'. The key needs to be set up in the resumed
kernel too. (Shouldn't be a problem, if you manage to suspend to it!).

Regards,

Nigel
-- 
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6253 0250 (home)

Evolution (n): A hypothetical process whereby infinitely improbable events occur 
with alarming frequency, order arises from chaos, and no one is given credit.

Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

[Andreas Jellinghaus]

[currently no scsi support]
ah, ok. 

> > btw: would it be somehow possible to resume after initrd phase?
> > or some other idea how a generic kernel with modules in the initrd
> > could use suspend to disk? or a laptop where the initrd is needed
> > to setup a dm-crypt volume with the right decrypton key?
> 
> That should be doable, provided that the initrd doesn't mount anything.
> Decryption is 'interesting'. The key needs to be set up in the resumed
> kernel too. (Shouldn't be a problem, if you manage to suspend to it!).

I don't know if loading modules can be done without, but the usual way
is to mount /sys and /proc so you can see what hardware is available.

I do that too for my dm-crypt setup, even mount a tmpfs at /dev,
create devices, start usb hotplugging, etc. but after getting the
decryption key, all filesystems are unmounted again, all processes
killed, there is nothing visible to me left. would that still create
some problems in the kernel internals preventing resume (or making it
too hard to do)?

Regards, Andras

Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

[Pavel Machek]

Hi!

> Applied to 2.4 and 2.6.

Bad idea. For swsusp2 the patch is bad because it can resume from 
after initrd (IIRC). For swsusp1 patch is bad
because it should be able to resume
from usb mass storage drive.

				Pavel
-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         

Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

[Nigel Cunningham]

Hi.

On Tue, 2004-03-30 at 17:31, Andreas Jellinghaus wrote:
> > That should be doable, provided that the initrd doesn't mount anything.
> > Decryption is 'interesting'. The key needs to be set up in the resumed
> > kernel too. (Shouldn't be a problem, if you manage to suspend to it!).
> 
> I don't know if loading modules can be done without, but the usual way
> is to mount /sys and /proc so you can see what hardware is available.

They would be fine. The key thing is that none of the filesystems which
have journals get mounted. That would cause the crash recovery routines
to run, resulting inconsistency between the image on disk and the one
that the suspend image contains. You could probably do just about
anything, so long as those filesystems aren't mounted. Assuming that is
done, actually calling suspend after an initrd is run shouldn't be a
problem, so far as I know.

Regards,

Nigel

-- 
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6253 0250 (home)

Evolution (n): A hypothetical process whereby infinitely improbable events occur 
with alarming frequency, order arises from chaos, and no one is given credit.

Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

[Nigel Cunningham]

Hi.

On Wed, 2004-03-31 at 06:11, Pavel Machek wrote:
> Hi!
> 
> > Applied to 2.4 and 2.6.
> 
> Bad idea. For swsusp2 the patch is bad because it can resume from 
> after initrd (IIRC). For swsusp1 patch is bad
> because it should be able to resume
> from usb mass storage drive.

So long as the initrd doesn't mess our filesystems up, we should be
okay, shouldn't we?

Nigel
-- 
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6253 0250 (home)

Evolution (n): A hypothetical process whereby infinitely improbable events occur 
with alarming frequency, order arises from chaos, and no one is given credit.

Re: [Swsusp-devel] [PATCH 2.6]: suspend to disk only available if non-modular IDE

[Pavel Machek]

Hi!

> > > Applied to 2.4 and 2.6.
> > 
> > Bad idea. For swsusp2 the patch is bad because it can resume from 
> > after initrd (IIRC). For swsusp1 patch is bad
> > because it should be able to resume
> > from usb mass storage drive.
> 
> So long as the initrd doesn't mess our filesystems up, we should be
> okay, shouldn't we?

As long as we test it once a while, yes.

But if resume from initrd works there's no reason to disallow modular
IDE... and that was what patch did.
								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]