public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Willy TARREAU <willy@w.ods.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH-2.4.26] cmpci cleanup
Date: Mon, 29 Mar 2004 09:19:46 -0300	[thread overview]
Message-ID: <20040329121945.GA22215@logos.cnet> (raw)
In-Reply-To: <20040328115718.GB24421@pcw.home.local>


WIlly,

We have a cmpci update pending and this error is really harmless,
so lets wait on this one.

On Sun, Mar 28, 2004 at 01:57:18PM +0200, Willy TARREAU wrote:
> Hi Marcelo,
> 
> compiling cmpci in 2.4.26-rc1 complains :
> 
> cmpci.c: In function `cm_probe':
> cmpci.c:3308: warning: unused variable `reg_mask'
> 
> Here is the patch. Please apply,
> Willy
> 
> --- ./drivers/sound/cmpci.c.orig	Sun Mar 28 11:19:12 2004
> +++ ./drivers/sound/cmpci.c	Sun Mar 28 11:19:44 2004
> @@ -3305,7 +3305,6 @@
>  	struct cm_state *s;
>  	mm_segment_t fs;
>  	int i, val, ret;
> -	unsigned char reg_mask = 0;
>  	struct {
>  		unsigned short	deviceid;
>  		char		*devicename;
> @@ -3381,6 +3380,7 @@
>  		printk(KERN_ERR "cmpci: io ports %#x-%#x in use\n", s->iomidi, s->iomidi+CM_EXTENT_MIDI-1);
>  		s->iomidi = 0;
>  	    } else {
> +		unsigned char reg_mask = 0;
>  		/* set IO based at 0x330 */
>  		switch (s->iomidi) {
>  		    case 0x330:
> @@ -3415,6 +3415,7 @@
>  		printk(KERN_ERR "cmpci: io ports %#x-%#x in use\n", s->iosynth, s->iosynth+CM_EXTENT_SYNTH-1);
>  		s->iosynth = 0;
>  	    } else {
> +		unsigned char reg_mask = 0;
>  		/* set IO based at 0x388 */
>  		switch (s->iosynth) {
>  		    case 0x388:

  reply	other threads:[~2004-03-29 12:37 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-28  4:26 Linux 2.4.26-rc1 Marcelo Tosatti
2004-03-28 11:47 ` Willy TARREAU
2004-03-28 11:54 ` [PATCH-2.4.26] ip6tables cleanup Willy TARREAU
2004-03-28 19:27   ` Peter Osterlund
2004-03-28 20:09     ` Willy TARREAU
2004-03-28 20:33       ` David S. Miller
2004-03-28 22:38         ` Willy TARREAU
2004-03-28 23:00           ` David S. Miller
2004-03-28 20:16     ` David S. Miller
2004-03-28 11:57 ` [PATCH-2.4.26] cmpci cleanup Willy TARREAU
2004-03-29 12:19   ` Marcelo Tosatti [this message]
2004-03-28 12:12 ` [PATCH-2.4.26] smbfs cleanup Willy TARREAU
2004-03-28 12:15 ` [PATCH-2.4.26] sddr09 cleanup Willy TARREAU
2004-03-28 12:18   ` Willy TARREAU
2004-03-28 12:21 ` [PATCH-2.4.26] drm/radeon_mem cleanup Willy TARREAU
2004-03-28 12:24 ` [PATCH-2.4.26] cardbus cleanup Willy TARREAU
2004-03-28 12:40 ` Linux 2.4.26-rc1 => Alpha warnings Willy TARREAU
2004-03-28 16:34   ` Ivan Kokshaysky
2004-03-28 12:58 ` [PATCH-2.4.26] ATM cleanup Willy TARREAU
2004-03-28 13:03   ` Chris Wedgwood
2004-03-28 13:08     ` Willy TARREAU
2004-03-30 17:44       ` chas williams (contractor)
2004-03-31  3:18         ` David S. Miller
2004-03-28 13:38 ` [PATCH-2.4.26] AGPGART cleanup Willy TARREAU
2004-03-28 15:24 ` Linux 2.4.26-rc1 Arkadiusz Miskiewicz
2004-03-28 19:11 ` Peter Osterlund
2004-03-28 20:41   ` Frédéric L. W. Meunier
2004-04-01  0:47   ` Linux 2.4.26-rc1 - SCTP 'make xconfig' issue Sridhar Samudrala
2004-04-01  5:24     ` Peter Osterlund
2004-04-01  7:05     ` David S. Miller
2004-04-01  7:29       ` Sridhar Samudrala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040329121945.GA22215@logos.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@w.ods.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox