Re: Unregistering interfaces

Andrew Morton
2004-03-30T23:14:47Z

Greg KH <greg@kroah.com> wrote:
>
> On Tue, Mar 30, 2004 at 11:21:35AM +0530, Maneesh Soni wrote:
> >
> > I am not very clear about how the first two behave. Still I can think
> > of a solution within sysfs like this as Alen suggested. But again I am not
> > very sure if this can be done properly without any races. But anyway I am
> > trying.
> >
> > 1) backout my patch sysfs-pin-kobject.patch
>
> I think we need to do this now, as it is not a correct fix, and causes
> more problems than good at this time.

But the patch was correct. sysfs retains a pointer to the kobject, it
should take a ref on it?

> I suggest you try to fix the oops
> you were seeing in either another way, or in a way that does not break
> other things :)

Didn't we demonstrate that the code which broke was already broken? And
that it has other problems regardless of the kobject pinning fix, such as the
userpace-holding-a-file-open-wedges-khubd problem?

Worried that this is all heading in the wrong direction...