Re: BUG_ON(!cpus_equal(cpumask, tmp));

Paul Jackson
2004-04-01T08:47:37Z

Hari,

I see code similar to what you are changing, also in the file:

arch/x86_64/kernel/smp.c

Do your considerations apply here as well?

===

static void flush_tlb_others(cpumask_t cpumask, struct mm_struct *mm,
unsigned long va)
{
cpumask_t tmp;
/* ... */
BUG_ON(cpus_empty(cpumask));
cpus_and(tmp, cpumask, cpu_online_map);
BUG_ON(!cpus_equal(tmp, cpumask));
BUG_ON(cpu_isset(smp_processor_id(), cpumask));
if (!mm)
BUG();
/* ... */

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373